Remove the GitStatus plugin. #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci please test |
grynspan
added
enhancement
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
Because this change requires Swift 5.11, I am holding on to it until we drop remaining support for Swift 5.10. |
grynspan
force-pushed
the
jgrynspan/remove-git-status-plugin
branch
from
38ad23b
to
a0d92fa
Compare
|
@swift-ci please test |
grynspan
force-pushed
the
jgrynspan/remove-git-status-plugin
branch
from
a0d92fa
to
f67e2d8
Compare
A recent PR on Swift Package Manager (apple/swift-package-manager#7202) added a `gitInformation` property to the package manifest's `Context` global. This property contains exactly the information we need from the GitStatus plugin. Let's remove it, then! Adopting the `gitInformation` property requires that we drop remaining support for Swift 5.10. We will continue to minimally support it in a separate Package.swift file (where we simply won't have git repo information at build time.) This PR does not strip out other 5.10 support code such as `XCTestScaffold`. Resolves rdar://121529847.
grynspan
force-pushed
the
jgrynspan/remove-git-status-plugin
branch
from
f67e2d8
to
f2c6e47
Compare
|
@swift-ci please test |
stmontgomery
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the GitStatus plugin.
A recent PR on Swift Package Manager (apple/swift-package-manager#7202) added a
gitInformationproperty to the package manifest'sContextglobal. This property contains exactly the information we need from the GitStatus plugin. Let's remove it, then!Adopting the
gitInformationproperty requires that we drop remaining support for Swift 5.10. We will continue to minimally support it in a separate Package.swift file (where we simply won't have git repo information at build time.) This PR does not strip out other 5.10 support code such asXCTestScaffold.Resolves rdar://121529847.
Checklist: