Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify when we're creating a TSC Thread and not a Foundation Thread #345

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Clarify when we're creating a TSC Thread and not a Foundation Thread #345

merged 1 commit into from
Jul 19, 2022

Conversation

DougGregor
Copy link
Member

Fixes an ambiguity that crops up with Sendable adoption (rdar://97223378).

@DougGregor
Clarify when we're creating a TSC Thread and not a Foundation Thread
e08105d 
Fixes an ambiguity that crops up with Sendable adoption (rdar://97223378).
@DougGregor
Copy link
Member Author

@swift-ci please test

phausler
phausler approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@phausler phausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@tomerd
Copy link
Member

tomerd commented Jul 18, 2022

@swift-ci test

@DougGregor
Copy link
Member Author

Err...

[22/31][ 70%][10.290s] Linking Swift static library lib/libXcodeproj.a
Aborted by [unknown](https://ci.swift.org/user/unknown)
Sending interrupt signal to process
[23/31][ 74%][13.181s] Linking Swift

@DougGregor
Copy link
Member Author

@swift-ci test

@DougGregor DougGregor merged commit 79be291 into main Jul 19, 2022
@fummicc1 fummicc1 mentioned this pull request Aug 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neonichu neonichu neonichu approved these changes

@tomerd tomerd tomerd approved these changes

@phausler phausler phausler approved these changes

@artemcm artemcm artemcm approved these changes

@aciidgh aciidgh Awaiting requested review from aciidgh

@abertelrud abertelrud Awaiting requested review from abertelrud

@friedbunny friedbunny Awaiting requested review from friedbunny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@DougGregor @tomerd @neonichu @phausler @artemcm