Explicitly mark objects of structured type with base class data #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base class data is vended as "just another child", which is mostly OK, except sometimes it's useful to know when the base class is being parsed vs. a member variable Relying on the name "super" isn't actually correct, but at the Mirror level we actually know base class vs. ivar This change propagates that knowledge via adding an extra byte to the payload for structured data in the logger format, such that the logger can tell consumers whether the 0th child is the base class or the first member variable rdar://problem/19072746
|
The Swift project moved the default branch to More detail about the branch update - https://forums.swift.org/t/updating-branch-names/40412 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base class data is vended as "just another child", which is mostly OK, except sometimes it's useful to know when the base class is being parsed vs. a member variable
Relying on the name "super" isn't actually correct, but at the Mirror level we actually know base class vs. ivar
This change propagates that knowledge via adding an extra byte to the payload for structured data in the logger format, such that the logger can tell consumers whether the 0th child is the base class or the first member variable
rdar://problem/19072746