[Availability] Lazily expand type refinement contexts for extensions.

apple · Feb 3, 2024 · 48eb4b7 · 48eb4b7
1 parent 11cb94f
commit 48eb4b7
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 11 deletions.
diff --git a/lib/Sema/TypeCheckAvailability.cpp b/lib/Sema/TypeCheckAvailability.cpp
@@ -551,6 +551,10 @@ class TypeRefinementContextBuilder : private ASTWalker {
       return true;
     }
 
+    if (isa<ExtensionDecl>(D)) {
+      return true;
+    }
+
     return false;
   }
 

diff --git a/test/Macros/macro_expand_extensions.swift b/test/Macros/macro_expand_extensions.swift
@@ -256,3 +256,13 @@ final class SendableClass {
 @AddSendable
 class InvalidSendableClass {
 }
+
+@AddSendable
+struct HasNestedType {
+  struct Inner {}
+}
+
+// Make sure no circularity error is produced when resolving
+// extensions of nested types when the outer type has an
+// attached macro that can add other nested types.
+extension HasNestedType.Inner {}
diff --git a/test/Sema/availability_refinement_contexts.swift b/test/Sema/availability_refinement_contexts.swift
@@ -73,8 +73,9 @@ protocol SomeProtocol {
   var protoProperty: Int { get }
 }
 
-// CHECK-NEXT: {{^}}  (decl versions=[10.51,+Inf) decl=extension.SomeClass
-// CHECK-NEXT: {{^}}    (decl versions=[10.52,+Inf) decl=someExtensionFunction()
+// CHECK-NEXT: {{^}}  (decl_implicit versions=[10.13,+Inf) decl=extension.SomeClass
+// CHECK-NEXT: {{^}}    (decl versions=[10.51,+Inf) decl=extension.SomeClass
+// CHECK-NEXT: {{^}}      (decl versions=[10.52,+Inf) decl=someExtensionFunction()
 @available(OSX 10.51, *)
 extension SomeClass {
   @available(OSX 10.52, *)
@@ -207,15 +208,16 @@ func functionWithWhile() {
   }
 }
 
-// CHECK-NEXT: {{^}}  (decl versions=[10.51,+Inf) decl=extension.SomeClass
-// CHECK-NEXT: {{^}}    (decl_implicit versions=[10.51,+Inf) decl=someStaticPropertyWithClosureInit
-// CHECK-NEXT: {{^}}      (decl versions=[10.52,+Inf) decl=someStaticPropertyWithClosureInit
-// CHECK-NEXT: {{^}}        (condition_following_availability versions=[10.54,+Inf)
-// CHECK-NEXT: {{^}}        (if_then versions=[10.54,+Inf)
-// CHECK-NEXT: {{^}}    (decl_implicit versions=[10.51,+Inf) decl=someStaticPropertyWithClosureInitInferred
-// CHECK-NEXT: {{^}}      (decl versions=[10.52,+Inf) decl=someStaticPropertyWithClosureInitInferred
-// CHECK-NEXT: {{^}}        (condition_following_availability versions=[10.54,+Inf)
-// CHECK-NEXT: {{^}}        (if_then versions=[10.54,+Inf)
+// CHECK-NEXT: {{^}}  (decl_implicit versions=[10.13,+Inf) decl=extension.SomeClass
+// CHECK-NEXT: {{^}}    (decl versions=[10.51,+Inf) decl=extension.SomeClass
+// CHECK-NEXT: {{^}}      (decl_implicit versions=[10.51,+Inf) decl=someStaticPropertyWithClosureInit
+// CHECK-NEXT: {{^}}        (decl versions=[10.52,+Inf) decl=someStaticPropertyWithClosureInit
+// CHECK-NEXT: {{^}}          (condition_following_availability versions=[10.54,+Inf)
+// CHECK-NEXT: {{^}}          (if_then versions=[10.54,+Inf)
+// CHECK-NEXT: {{^}}      (decl_implicit versions=[10.51,+Inf) decl=someStaticPropertyWithClosureInitInferred
+// CHECK-NEXT: {{^}}        (decl versions=[10.52,+Inf) decl=someStaticPropertyWithClosureInitInferred
+// CHECK-NEXT: {{^}}          (condition_following_availability versions=[10.54,+Inf)
+// CHECK-NEXT: {{^}}          (if_then versions=[10.54,+Inf)
 @available(OSX 10.51, *)
 extension SomeClass {
   @available(OSX 10.52, *)

diff --git a/test/stdlib/Observation/Observable.swift b/test/stdlib/Observation/Observable.swift
@@ -225,6 +225,12 @@ class GuardedAvailability {
   }()
 }
 
+@Observable class Parent {
+  class Nested {}
+}
+
+extension Parent.Nested {}
+
 struct CowContainer {
   final class Contents { }