New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SR-5036]: Segfault using KeyPath with NSObject #10302
Conversation
@swift-ci Please test |
Build failed |
Build failed |
@aciidb0mb3r This swiftpm failure ring a bell?
|
@jckarter Nope, haven't seen this failure before. |
9e37818
to
66dbec0
Compare
@swift-ci Please test |
1 similar comment
@swift-ci Please test |
Build failed |
…nly. We would lay out all classes starting with a Swift-style two-word header, even classes that inherit NSObject and therefore don't have Swift refcounting. The ObjC runtime would slide our ivars down for us at realization time, but it's nice to avoid unnecessarily dirtying memory in the not-uncommon case of direct NSObject subclasses.
…n NSObject subclasses. We need to use the ivar offset variables in this case, since the Swift field offset vector doesn't pick up the adjusted offsets from the ObjC runtime. Fixes SR-5036 | rdar://problem/32488871.
66dbec0
to
fe88bd5
Compare
@swift-ci Please test |
Build failed |
@swift-ci Please test |
We need to use the ivar offset variables in this case, since the Swift field offset vector doesn't pick up the adjusted offsets from the ObjC runtime. Fixes SR-5036 | rdar://problem/32488871.