New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow synthesis of Codable for weak/unowned vars #10321

Merged
merged 1 commit into from Jun 16, 2017

Conversation

Projects
None yet
1 participant
@itaiferber
Contributor

itaiferber commented Jun 16, 2017

What's in this pull request?
Allows non-strong (i.e. weak/unowned/unmanaged) vars to participate in Codable synthesis.

The type of non-strong properties is wrapped in a ReferenceStorageType, which does not conform to Codable. This needs to be unwrapped so the inner reference type can be considered for Codable conformance.

Allow synthesis of Codable for weak/unowned vars
The type of non-strong properties is wrapped in a ReferenceStorageType,
which does not conform to Codable. This needs to be unwrapped so the
inner reference type can be considered for Codable conformance.
@itaiferber

This comment has been minimized.

Show comment
Hide comment
@itaiferber

itaiferber Jun 16, 2017

Contributor

@swift-ci Please test

Contributor

itaiferber commented Jun 16, 2017

@swift-ci Please test

@itaiferber itaiferber requested review from DougGregor and jrose-apple Jun 16, 2017

@itaiferber itaiferber merged commit c277aa1 into apple:master Jun 16, 2017

4 checks passed

Swift Test Linux Platform 9954 tests run, 0 skipped, 0 failed.
Details
Swift Test Linux Platform (smoke test)
Details
Swift Test OS X Platform 40020 tests run, 0 skipped, 0 failed.
Details
Swift Test OS X Platform (smoke test)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment