replace asserts with nicer ValueErrors in gyb #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Please clean up the patch so that there are no unrelated whitespace changes. |
JHoloboski
force-pushed
the
fix/proper-raise
branch
from
54c6880
to
ebd253b
Compare
|
@gribozavr Done! |
| @@ -464,10 +464,14 @@ def tokenGenerator(self, baseTokens): | |||
| if (kind == 'gybBlockOpen'): | |||
| # Absorb any '}% <optional-comment> \n' | |||
| m2 = gybBlockClose.match(self.template, closePos) | |||
| assert m2, "Invalid block closure" # FIXME: need proper error handling here. | |||
| if m2 is None: | |||
There was a problem hiding this comment.
Is this equivalent? I thought the equivalent would be if not m2:.
There was a problem hiding this comment.
It would be also great to add a test for this.
There was a problem hiding this comment.
Yeah that would be better, fixing.
JHoloboski
force-pushed
the
fix/proper-raise
branch
from
ebd253b
to
089a967
Compare
|
|
||
| if context.localBindings['__children__'] is not self.children: | ||
| raise ValueError( | ||
| "Expected bindings to be {}, got {}".format( |
There was a problem hiding this comment.
This error message isn't precise enough. It should say, I think, "The code is not allowed to mutate __children__".
Here's a test:
%{
__children__ = 42
}%
|
@JHoloboski Thank you! Would you mind squashing 5 commits into one and rebasing on top of current master? |
JHoloboski
force-pushed
the
fix/proper-raise
branch
from
8c1472e
to
7fb230a
Compare
|
@gribozavr Done :) |
gribozavr
added a commit
that referenced
this pull request
Dec 22, 2015
replace asserts with nicer ValueErrors in gyb
|
Did anyone look at the actual results of this? What does the "nicer feedback" look like? |
slavapestov
pushed a commit
to slavapestov/swift
that referenced
this pull request
Nov 27, 2018
define SWIFT_CC(swift) macro for DispatchStubs
slavapestov
pushed a commit
to slavapestov/swift
that referenced
this pull request
Nov 27, 2018
define SWIFT_CC(swift) macro for DispatchStubs Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
maldahleh
pushed a commit
to maldahleh/swift
that referenced
this pull request
Oct 26, 2020
Disable grouping temporarily because there are no associated group for lit-test-helper
freak4pc
pushed a commit
to freak4pc/swift
that referenced
this pull request
Sep 28, 2022
XFAIL Plank and R
DougGregor
pushed a commit
to DougGregor/swift
that referenced
this pull request
Apr 28, 2024
Rename _MatchingEngine to _RegexParser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw the fixme in this file on the assert, so: