New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Fix another subtle SE-0110-related break. #10848
Conversation
@swift-ci Please test |
@swift-ci Please test source compatibility |
Build failed |
The change to roll back a part of SE-0110 to allow multi-argument functions to be passed in places where functions taking a tuple are expected resulted in a regression in some cases where the fix would strip off the last ParenType from single-argument functions. Instead of stripping off parens from both function types we're trying to match when they both have them, strip off none. This ensures that we don't get summarily rejected in the nested matchTypes call by other SE-0110-related code that bails if the two types do not have the same "parenness". Fixes rdar://problem/33043106 / SR-5387. (cherry picked from commit acfa800341785ee73548369a4456118365005002)
@swift-ci Please test |
Build failed |
@swift-ci Please test |
@swift-ci Please test source compatibility |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already approved the master version of this
@swift-ci Please test source compatibility |
The change to roll back a part of SE-0110 to allow multi-argument
functions to be passed in places where functions taking a tuple are
expected resulted in a regression in some cases where the fix would
strip off the last ParenType from single-argument functions.
Instead of stripping off parens from both function types we're trying to
match when they both have them, strip off none. This ensures that we
don't get summarily rejected in the nested matchTypes call by other
SE-0110-related code that bails if the two types do not have the same
"parenness".
Fixes rdar://problem/33043106 / SR-5387.