[4.0] SILGen: Remove unused catch block for a try? expr using SGF.eraseBasicBlock(). #11009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cBlock(). Erasing the block directly from its parent using bb->eraseFromParent() doesn't update SILGenFunction's internal state tracking the postmatter section of the function. Fixes SR-1333 | rdar://problem/33351098.
|
@swift-ci Please test source compatibility |
|
@swift-ci Please test |
|
@rjmccall Mind reviewing this for the 4.0 branch? Got any ideas on how we can more proactively prevent this mistake? |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: A
try?expression that didn't include any throwing in its subexpression would corrupt SILGen's internal state, leading to compiler crashes.Scope of issue: Because it's an internal consistency issue, some code that happened to seem to work with Swift 3.1 releases will now crash in 4.0 builds, leading to regressions.
Issue: SR-1333, rdar://problem/33351098
Risk: Low, one-line bug fix
Testing: Swift CI, test cases from Jira