[4.0] Sema: Don't allow key path literals to refer to static members. #11062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
@xedin Does this look good for the 4.0 branch? |
jckarter
changed the title
This is theoretically supportable some day, but isn't implemented today. Fixes rdar://problem/33318422 | SR-5453. (cherry picked from commit 70d2ef14381fcc61ea998846599ae59252d0dcfe)
jckarter
force-pushed
the
static-key-path-error-4.0
branch
from
6337d06
to
76fda38
Compare
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Forming a key path that referenced a static property would crash the compiler.
Scope: Crash on invalid
Issue: rdar://problem/33318422 | SR-5453
Risk: Low, raises an error on invalid code that previously crashed the compiler; isolated to key paths
Testing: Swift CI, test case from Jira