Porting to cygwin #1108

tinysun212 · 2016-01-26T23:04:32Z

Rebased PR from previous.
I made several changes set for cygwin64 port.

The standard library can be used and It is possible to compile and run or interpret a simple hello swift source, but REPL, swift-build and swift-lldb does not work.
Currently, build process is not good, and many bugs may exist in.

tinysun212 · 2016-01-26T23:12:05Z

I'll made more patches for stdlib/public/stubs/Stubs.cpp, stdlib/public/stubs/UnicodeNormalization.cpp,
include/swift/Basic/Dwarf.h.

gribozavr · 2016-01-27T17:20:37Z

include/swift/Runtime/Once.h

+
+// On Cygwin, std::once_flag can not be used because it is larger than the
+// platform word.
+typedef unsigned long swift_once_t;


uintptr_t might be a better fit?

It seems other implementations (Linux, Cygwin internal.. ) didn't use a pointer type, so I chosen that.

We don't want a pointer, we want a pointer-sized int.

I misunderstand about uintptr_t. I'll change to it. Thank you.

gribozavr · 2016-01-28T18:56:00Z

@tinysun212 Thank you for your updates! I made more comments, please take a look.

gribozavr · 2016-01-28T18:56:10Z

This is looking really good now, by the way!

jckarter · 2016-02-01T23:24:35Z

stdlib/public/core/Builtin.swift

+#if os(Windows)
+// If the return type of a C/C++ function is a structure,
+// the calling convension is different from caller's.  
+// A wrapper function is introduced.


Can you change TwoWordPair::Return in the runtime to be an __int128 on Win64 instead of exposing the C calling convention difference in Swift code?

I'll try it.

tinysun212 · 2016-02-12T01:35:14Z

I'm waiting reviews for correction. If there is nothing to correct, what should I do with this PR?

gribozavr · 2016-02-12T02:26:56Z

stdlib/public/stubs/Stubs.cpp

+  ValueStream.imbue(std::locale::classic());
+  ValueStream << Value;
+  std::string  ValueString(ValueStream.str());
+  int i = ValueString.length();


The variable should be declared as size_t instead of a cast on the line below.

tinysun212 · 2016-02-13T09:36:55Z

This PR conflicted again. I don't know how to resolve this. Should I rebase to top of master and recreate another PR ?

gribozavr · 2016-02-13T10:24:13Z

@tinysun212 You can rebase, squash, and git push -f to the same branch just one commit. Github will automatically update the PR. Alternatively, you can submit a new PR, whichever is simpler.

tinysolver · 2016-02-13T15:36:53Z

I rebased and squashed all previous commits to one. And fixed some compile errors. Thank you.

gribozavr · 2016-02-13T23:20:23Z

stdlib/public/runtime/CygwinPort.cpp

+
+  int lastRet = 0;
+
+  // HMODULE modules[1024];


Remove commented code?

gribozavr · 2016-02-13T23:23:43Z

@swift-ci Please test

gribozavr · 2016-02-13T23:41:18Z

@tinysun212 Would you mind fixing the CMake issues that the buildbot found? You'd need to use set(LLVM_OPTIONAL_SOURCES ...) for the appropriate files.

gribozavr · 2016-02-19T17:00:11Z

@swift-ci Please test

tinysun212 · 2016-02-19T23:36:54Z

Currently, I have Linux and Windows platforms for development and not OS X platform.
Could somebody tell me the point that cause the test failed or any hint to solve this ?

gribozavr · 2016-02-19T23:41:17Z

@tinysun212 Sorry, the OS X tests failing is not your fault. The master branch is broken now, we are working to get it fixed. This should land imminently and we'll re-run tests then.

gribozavr · 2016-02-20T11:33:07Z

@swift-ci Please test

gribozavr · 2016-02-22T01:07:10Z

@tinysun212 I'm sorry, could you fix the conflicts? The patch LGTM, I will merge immediately!

gribozavr · 2016-02-22T08:16:30Z

@tinysun212 Thank you!

gribozavr · 2016-02-22T08:16:32Z

@swift-ci Please smoke test

gribozavr · 2016-02-22T08:49:20Z

@tinysun212 CI found an issue on Linux:

CMake Error at /home/buildnode/jenkins/workspace/swift-PR-Linux@2/Ninja-ReleaseAssert/llvm-linux-x86_64/share/llvm/cmake/LLVMProcessSources.cmake:83 (message):
  Found unknown source file
  /home/buildnode/jenkins/workspace/swift-PR-Linux@2/swift/stdlib/public/runtime/CygwinPort.cpp

To fix, please merge the two definitions of LLVM_OPTIONAL_SOURCES into one (file stdlib/public/runtime/CMakeLists.txt).

gribozavr · 2016-02-22T16:48:33Z

@swift-ci Please smoke test

gribozavr · 2016-02-22T17:05:27Z

@tinysun212 Sorry, CI is not happy again. You need to merge the definition into the top one, because there is an add_swift_library in between.

tinysun212 · 2016-02-22T23:02:11Z

@gribozavr I'm sorry repetitive fail in same position. In this time, I tested the cmake-running (not build) in Linux.

gribozavr · 2016-02-23T00:16:08Z

@swift-ci Please test

tinysun212 · 2016-02-23T02:49:00Z

OS X tests failed again. I think it is not my fault. Let me know if my action is needed.

gribozavr · 2016-02-23T02:53:28Z

@tinysun212 Yes, that's existing breakage. Merging! Thank you for working on this!

Porting to cygwin

gribozavr mentioned this pull request Jan 27, 2016

Porting to cygwin #1010

Closed

gribozavr reviewed Jan 27, 2016
View reviewed changes

jckarter reviewed Feb 1, 2016
View reviewed changes

gribozavr reviewed Feb 12, 2016
View reviewed changes

tinysun212 force-pushed the porting-to-cygwin branch from 6b98e0b to 2460d9e Compare February 13, 2016 09:08

tinysun212 force-pushed the porting-to-cygwin branch from 2460d9e to 246d9f2 Compare February 13, 2016 15:32

gribozavr reviewed Feb 13, 2016
View reviewed changes

stdlib/public/runtime/CygwinPort.cpp

int lastRet = 0;

// HMODULE modules[1024];

Copy link

Collaborator

gribozavr Feb 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented code?

tinysun212 force-pushed the porting-to-cygwin branch from 88204ab to 23fb980 Compare February 18, 2016 22:54

Porting to Cygwin. rebased and squashed

e06c713

tinysun212 force-pushed the porting-to-cygwin branch from 23fb980 to e06c713 Compare February 22, 2016 04:21

Merged LLVM_OPTION_SOURCES in runtime CMakeLists.txt

f0e10a2

Moved LLVM_OPTIONAL_SOURCES

8c829ee

gribozavr added a commit that referenced this pull request Feb 23, 2016

Merge pull request #1108 from tinysun212/porting-to-cygwin

7235595

Porting to cygwin

gribozavr merged commit 7235595 into apple:master Feb 23, 2016

modocache mentioned this pull request Feb 25, 2016

Port to Android #1442

Merged

tinysun212 deleted the porting-to-cygwin branch October 21, 2018 00:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Porting to cygwin #1108

Porting to cygwin #1108

tinysun212 commented Jan 26, 2016

tinysun212 commented Jan 26, 2016

gribozavr Jan 27, 2016

tinysun212 Jan 28, 2016

jckarter Feb 1, 2016

tinysun212 Feb 2, 2016

gribozavr commented Jan 28, 2016

gribozavr commented Jan 28, 2016

jckarter Feb 1, 2016

tinysun212 Feb 2, 2016

tinysun212 commented Feb 12, 2016

gribozavr Feb 12, 2016

tinysun212 commented Feb 13, 2016

gribozavr commented Feb 13, 2016

tinysolver commented Feb 13, 2016

gribozavr Feb 13, 2016

gribozavr commented Feb 13, 2016

gribozavr commented Feb 13, 2016

gribozavr commented Feb 19, 2016

tinysun212 commented Feb 19, 2016

gribozavr commented Feb 19, 2016

gribozavr commented Feb 20, 2016

gribozavr commented Feb 22, 2016

gribozavr commented Feb 22, 2016

gribozavr commented Feb 22, 2016

gribozavr commented Feb 22, 2016

gribozavr commented Feb 22, 2016

gribozavr commented Feb 22, 2016

tinysun212 commented Feb 22, 2016

gribozavr commented Feb 23, 2016

tinysun212 commented Feb 23, 2016

gribozavr commented Feb 23, 2016

Porting to cygwin #1108

Porting to cygwin #1108

Conversation

tinysun212 commented Jan 26, 2016

tinysun212 commented Jan 26, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gribozavr commented Jan 28, 2016

gribozavr commented Jan 28, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tinysun212 commented Feb 12, 2016

Choose a reason for hiding this comment

tinysun212 commented Feb 13, 2016

gribozavr commented Feb 13, 2016

tinysolver commented Feb 13, 2016

Choose a reason for hiding this comment

gribozavr commented Feb 13, 2016

gribozavr commented Feb 13, 2016

gribozavr commented Feb 19, 2016

tinysun212 commented Feb 19, 2016

gribozavr commented Feb 19, 2016

gribozavr commented Feb 20, 2016

gribozavr commented Feb 22, 2016

gribozavr commented Feb 22, 2016

gribozavr commented Feb 22, 2016

gribozavr commented Feb 22, 2016

gribozavr commented Feb 22, 2016

gribozavr commented Feb 22, 2016

tinysun212 commented Feb 22, 2016

gribozavr commented Feb 23, 2016

tinysun212 commented Feb 23, 2016

gribozavr commented Feb 23, 2016