[4.0] SILGen: The allocator entry point for an initializer is never dynamic.
#11108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The allocating thunk handles the `dynamic`-ness of the initializing entry point, which maps to an underlying `-initWith*:` ObjC method, and cannot itself be treated as `dynamic`. Fixes SR-5223 | rdar://problem/32778104. (cherry picked from commit e6b356a)
|
@slavapestov Mind reviewing this for 4.0? |
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
slavapestov
approved these changes
Jul 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: We would miscompile
requiredinitializer in subclasses of Objective-C classes, causing aninitmessage to be sent to the class object rather than an allocated instance of the object.Scope: This was a latent bug in
dynamicinitializers, aggravated by our change to make all ObjC-compatible interfaces implicitlydynamicin order to ensure cross-language-version compatibility, making it a regression for existing code.Issue: SR-5223 | rdar://problem/32778104.
Risk: Low, small bug fix.
Testing: Swift CI, compatibility suite, test case from Jira.