[SourceKit] Add typealias to doc structure - SR-4828 #11143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great, thank you for doing this ✨. Somebody that owns SourceKit should give you approval here, but in the meantime @swift-ci please smoke test |
|
This is great improvement! Could you also add a lib/ide test in addition to the source kit test? You can find similar test in |
johnfairh
force-pushed
the
sourcekit-structure-typealias
branch
from
032db35
to
2b3c710
Compare
|
@swift-ci please smoke test |
|
Added lib/ide test. |
|
Looks good. Merging. |
|
Great - thanks both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
typealiasdeclarations to the SourceKit document structure as included in the response from source.request.editor.open.{ interface/ interface.header/ interface.swiftsource/ interface.swifttype} and editor.replacetext. Update tests.Resolves SR-4828.
One reason why it’s important for SourceKit clients to have all declarations included in doc structure is that it is the only interface that includes accessibility. There are 3-4 decl types missing/wrong right now.
This PR is pretty tentative: I can believe there are Xcode dependencies making it impractical for community changes to this part of the code, but I thought it was worth a shot. I built a toolchain and Xcode seems happy enough with it, not comprehensive ofc.
Code note: I added the new enum case alongside the other decl enum cases rather than at the end because the enum does not look to get persisted anywhere.