[SE-0157] [Collections] Constrain Indices type to Collection. #11918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When setting the signature conformances in a NormalProtocolConformance, do so progressively rather than waiting until all of them are computed. This allows later requirements to refer to earlier conformances.
…ection. Introduce (recursive) constraints that make the *Collection constraint of SubSequence match that of its enclosing *Collection, e.g., MutableCollection.SubSequence conforms to MutableCollection. Fixes rdar://problem/20715031 and more of SR-3453.
Make the Indices types conform to the appropriate Collection protocol: * Collection.Indices: Collection * BidirectionalCollection.Indices: BidirectionalCollection * RandomAccessCollection.Indices: RandomAccessCollection
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
DougGregor
changed the title
|
I'm going to collect all of the standard library changes for SE-0157: Recursive Protocol Constraints in a single PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the
Indicesassociated types conform to the appropriateCollectionprotocol:Collection.Indices: CollectionBidirectionalCollection.Indices: BidirectionalCollectionRandomAccessCollection.Indices: RandomAccessCollectionAnd clean up all of the now-redundant constraints. This builds on top of #11899. It fixes the remainder of SR-3453 that I don't find "suspicious".