add /usr/include/sysexits.h to Glibc module #11926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! @swift-ci please test |
|
Build failed |
CodaFi
reviewed
Sep 17, 2017
| header "${GLIBC_INCLUDE_PATH}/sysexits.h" | ||
| export * | ||
| } | ||
| % end |
There was a problem hiding this comment.
I have no idea why gyb is complaining here, but you should check that you haven't introduced any unnecessary invisibles or metachars.
There was a problem hiding this comment.
That was exactly it. Sorry about that!
It is part of the Darwin module; this makes things more consistent.
glessard
force-pushed
the
linux-sysexits
branch
from
73a5846
to
cff2064
Compare
|
@swift-ci please smoke test |
|
While you're in the area, would you mind taking a look at #11117? |
|
⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
sysexits.hheader to the Glibc system module.sysexits.his part of the Darwin module, but is not imported by Linux's Glibc. Since the file also exists on Linux and FreeBSD, including it removes a small, seemingly unnecessary inconsistency.Resolves SR-3436.