[SourceKit] Introduce "source.lang.swift.expr.tuple" (SR-5977) #12089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkcsgexi
reviewed
Sep 25, 2017
lib/IDE/SyntaxModel.cpp
Outdated
| Tup->getSourceRange()); | ||
|
|
||
| for (auto *Elem : Tup->getElements()) { | ||
| if (auto *TupleE = dyn_cast<TupleExpr>(Elem)) { |
There was a problem hiding this comment.
Why do we only care about the second level as a tuple and why do we flatten it?
There was a problem hiding this comment.
Because I copied and pasted from somewhere else 😅
Fixed!
marcelofabri
force-pushed
the
sourcekit-tuple
branch
from
0fdc781
to
fa6f627
Compare
|
@swift-ci please smoke test |
|
The CI failure seems unrelated. |
|
@swift-ci please smoke test |
|
@swift-ci Please clean smoke test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
source.lang.swift.expr.tupleto represent tuple expressions, similar tosource.lang.swift.expr.arrayandsource.lang.swift.expr.dictionary.Currently this only works for tuple expressions (i.e. it won't report a tuple in types as
let x: (Y, Z)). However, probably this is the expected behavior for expression kinds anyway.This also doesn't provide any extra information for named tuples, but I think this can be done later.
Resolves SR-5977.
// cc @nkcsgexi