Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SR-5753: Don't warn about constraints redundant with inferred constraints #12135

Merged
merged 1 commit into from Sep 27, 2017
Merged

SR-5753: Don't warn about constraints redundant with inferred constraints #12135

merged 1 commit into from Sep 27, 2017

Conversation

DougGregor
Copy link
Member

@DougGregor DougGregor commented Sep 27, 2017 •
edited

Stop warning about constraints made redundant due to inferred constraints, e.g., don't warn on this:

struct S<T: Hashable> {}
fun f<T: Equatable>(s: S<T>) {}

because T: Hashable was inferred from S: T. Addresses https://bugs.swift.org/browse/SR-5753.

@DougGregor
Copy link
Member Author

@swift-ci please smoke test

@DougGregor DougGregor merged commit 98e88bc into apple:master Sep 27, 2017
@DougGregor DougGregor deleted the sr-5753 branch September 27, 2017 16:03
@NachoSoto
Copy link
Contributor

❤️ I think this is the perfect solution IMO.

@DougGregor DougGregor mentioned this pull request Sep 27, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DougGregor @NachoSoto