runtime: Move String implementation stubs that want need the auto-rel… #12312
Conversation
…eased return value optimization to an ARC compiled file String's hashValue function is implemented in terms of Foundation's hash function in a runtime function on darwin platforms. For non-ASCII strings we will call str.decomposedStringWithCanonicalMapping inside this runtime function which will allocate a new NSString and return the result in the current autorelease pool. We implemented this function in a file compiled without ARC. This meant that we would leak said NSString into the current active autorelease pool. This patch moves the implementation to a file compiled with ARC. ARC will insert objc_retainAutoreleasedReturnValue call and on platforms that require it an marker for the hand-off of the autoreleased return value optimization. SR-4889 rdar://32199117
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
| /// The following two routines need to be implemented in ARC because | ||
| /// decomposedStringWithCanonicalMapping returns its result autoreleased. And we | ||
| /// want ARC to insert 'objc_retainAutoreleasedReturnValue' and the necessary | ||
| /// markers for the hand-off. |
There was a problem hiding this comment.
Nitpick: this shouldn't be a doc comment.
test/stdlib/StringMemoryTest.swift
Outdated
| // REQUIRES: objc_interop | ||
|
|
||
| // The autorelease return optimizaion seems to be failing in the simulator. | ||
| // XFAIL: CPU=i386 |
There was a problem hiding this comment.
I think we just don't do it there. @rjmccall?
There was a problem hiding this comment.
Yes, seems to be the case. I tried with a pure objective-c app and we also leak there on an i386 simulator rdar://34863458
| @@ -0,0 +1,101 @@ | |||
| // UNSUPPORTED: linux | |||
There was a problem hiding this comment.
Better to make this REQUIRES: objc_interop. This won't work on Windows or Android either, after all.
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
@aschwaighofer Please be careful about using the word leak and autorelease pool together. Hitting the autorelease pool is not a "leak". I would say "unnecessary memory growth" or something like that. Leak is misleading. Or am I misunderstanding the pull request? |
|
@swift-ci Please clean test linux |
|
@swift-ci Please clean test |
|
Build failed |
|
Build failed |
…eased return value optimization to an ARC compiled file
String's hashValue function is implemented in terms of Foundation's hash
function in a runtime function on darwin platforms. For non-ASCII strings we
will call str.decomposedStringWithCanonicalMapping inside this runtime function
which will allocate a new NSString and return the result in the current
autorelease pool. We implemented this function in a file compiled without ARC.
This meant that we would leak said NSString into the current active autorelease
pool.
This patch moves the implementation to a file compiled with ARC. ARC will insert
objc_retainAutoreleasedReturnValue call and on platforms that require it an
marker for the hand-off of the autoreleased return value optimization.
SR-4889
rdar://32199117