New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stdlib] Fix FloatingPoint.init(exactly:) #12739
Conversation
This initializer wasn't actually checking the exact conversion. Corrects the tests as well.
Please test with following pull request: @swift-ci Please test |
Build failed |
Build failed |
Please test with following pull request: @swift-ci Please test |
Please test with following pull request: @swift-ci Please test Linux platform |
Build failed |
Please test with following pull request: @swift-ci Please test Linux platform |
@gparker42 What do you think? I think the issue last time was that smoke tests don't run the 32-bit simulator tests—this should be in a better state. |
That sounds plausible. I see that the tests here ran on watchOS simulator which should cover 32-bit. The only difference between this and #11311 is test changes, correct? |
That's right—it's just what's in that last commit. |
Thanks, Nate. |
This is another attempt at fixing this initializer — #11311 had to be reverted after a test failure that didn't show up during CI.