Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stdlib] Fix FloatingPoint.init(exactly:) #12739

Merged
merged 3 commits into from Nov 6, 2017

Conversation

natecook1000
Copy link
Member

This is another attempt at fixing this initializer — #11311 had to be reverted after a test failure that didn't show up during CI.

This initializer wasn't actually checking the exact conversion. Corrects
the tests as well.
@natecook1000
Copy link
Member Author

Please test with following pull request:
apple/swift-corelibs-foundation#1293

@swift-ci Please test

@swift-ci
Copy link
Collaborator

swift-ci commented Nov 3, 2017

Build failed
Swift Test OS X Platform
Git Sha - 3870091

@swift-ci
Copy link
Collaborator

swift-ci commented Nov 3, 2017

Build failed
Swift Test Linux Platform
Git Sha - 3870091

@natecook1000
Copy link
Member Author

Please test with following pull request:
apple/swift-corelibs-foundation#1293

@swift-ci Please test

@apple apple deleted a comment from swift-ci Nov 3, 2017
@apple apple deleted a comment from swift-ci Nov 3, 2017
@natecook1000
Copy link
Member Author

Please test with following pull request:
apple/swift-corelibs-foundation#1293

@swift-ci Please test Linux platform

@swift-ci
Copy link
Collaborator

swift-ci commented Nov 3, 2017

Build failed
Swift Test Linux Platform
Git Sha - f3a5af8

@natecook1000
Copy link
Member Author

Please test with following pull request:
apple/swift-corelibs-foundation#1293

@swift-ci Please test Linux platform

@natecook1000
Copy link
Member Author

@gparker42 What do you think? I think the issue last time was that smoke tests don't run the 32-bit simulator tests—this should be in a better state.

@gparker42
Copy link
Contributor

That sounds plausible. I see that the tests here ran on watchOS simulator which should cover 32-bit.

The only difference between this and #11311 is test changes, correct?

@natecook1000
Copy link
Member Author

That's right—it's just what's in that last commit.

@gparker42 gparker42 merged commit dcf6e2b into apple:master Nov 6, 2017
@gparker42
Copy link
Contributor

Thanks, Nate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants