[overlay] Use precondition instead of fatalError in DateInterval initializer #12743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, thanks. |
|
@parkera what about "test and merge" 🤔 ? |
|
@swift-ci please smoke test |
|
Rebased and updated this patch. Going to merge it in #28317 So, so sorry we didn't get around to merging this at the time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comment of the function says:
but it actually uses
if -> fatalErrorinstead ofprecondition,Other functions of
DateIntervaluseprecondition-s, only this one usesfatalError, probably makes sense to change it as well.Similar to apple/swift-corelibs-foundation#1292
@parkera