Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Don't merge] Use conditional conformances to implement Equatable for Optional, Array and Dictionary #12868

Closed
wants to merge 2 commits into from
Closed

[Don't merge] Use conditional conformances to implement Equatable for Optional, Array and Dictionary #12868

wants to merge 2 commits into from

Conversation

huonw
Copy link
Contributor

@huonw huonw commented Nov 11, 2017

No description provided.

slavapestov
slavapestov reviewed Nov 11, 2017
View reviewed changes
stdlib/public/core/Arrays.swift.gyb
) -> Bool {
return !(lhs == rhs)
/// Returns `true` if the arrays do not contain the same elements.
@_inlineable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@airspeedswift We no longer need to define operator!= do we?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless its implementation is more efficient than !(==).

slavapestov
slavapestov reviewed Nov 11, 2017
View reviewed changes
stdlib/public/core/Optional.swift
/// - lhs: An optional value to compare.
/// - rhs: Another optional value to compare.
@_inlineable
public static func !=(lhs: Wrapped?, rhs: Wrapped?) -> Bool {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

@moiseev
Copy link
Contributor

moiseev commented Nov 11, 2017

@swift-ci Please smoke test

@moiseev
Copy link
Contributor

moiseev commented Nov 11, 2017

@swift-ci please smoke test compiler performance

@swift-ci
Copy link
Collaborator

Build comment file:

Summary for master smoketest

Regressions found (see below)

Debug

PR vs. head (debug)

PR vs. head, changed counters (debug)

Regressed (33)
Regressed in Alamofire (5)
name old new delta delta_pct
Sema.NumLazyIterableDeclContexts 18998 19075 77 0.41% ⛔
Sema.NumDeclsDeserialized 186159 186454 295 0.16% ⛔
SILModule.NumSILOptFunctions 4747 4754 7 0.15% ⛔
Sema.NumTypesDeserialized 151693 151910 217 0.14% ⛔
Sema.NumConformancesDeserialized 34854 34891 37 0.11% ⛔
Regressed in Kingfisher (10)
name old new delta delta_pct
AST.NumUsedConformances 842 850 8 0.95% ⛔
Sema.NumLazyIterableDeclContexts 48591 48767 176 0.36% ⛔
Sema.NumDeclsDeserialized 343260 343804 544 0.16% ⛔
Sema.NumTypesDeserialized 283038 283480 442 0.16% ⛔
IRModule.NumIRFunctions 8123 8135 12 0.15% ⛔
IRModule.NumIRValueSymbols 14793 14815 22 0.15% ⛔
IRModule.NumIRGlobals 9033 9043 10 0.11% ⛔
LLVM.NumLLVMBytesOutput 5068656 5071892 3236 0.06% ⛔
IRModule.NumIRInsts 183280 183370 90 0.05% ⛔
SILModule.NumSILOptFunctions 8603 8607 4 0.05% ⛔
Regressed in ReactiveCocoa (6)
name old new delta delta_pct
Sema.NumTypesDeserialized 365806 367789 1983 0.54% ⛔
Sema.NumLazyIterableDeclContexts 94390 94792 402 0.43% ⛔
Sema.NumDeclsDeserialized 398813 399891 1078 0.27% ⛔
Sema.NumLazyGenericEnvironments 67026 67190 164 0.24% ⛔
SILModule.NumSILOptFunctions 4369 4378 9 0.21% ⛔
Sema.NumConformancesDeserialized 47508 47594 86 0.18% ⛔
Regressed in ReactiveSwift (6)
name old new delta delta_pct
Sema.NumLazyIterableDeclContexts 27672 27812 140 0.51% ⛔
Sema.NumGenericSignatureBuilders 8826 8842 16 0.18% ⛔
Sema.NumDeclsDeserialized 244864 245258 394 0.16% ⛔
Sema.NumTypesDeserialized 209453 209737 284 0.14% ⛔
Sema.NumConformancesDeserialized 48170 48234 64 0.13% ⛔
Sema.NumLazyGenericEnvironments 40444 40454 10 0.02% ⛔
Regressed in Result (6)
name old new delta delta_pct
Sema.NumLazyIterableDeclContexts 2844 2862 18 0.63% ⛔
Sema.NumTypesDeserialized 19880 20000 120 0.6% ⛔
Sema.NumDeclsDeserialized 22863 22973 110 0.48% ⛔
SILModule.NumSILOptFunctions 642 644 2 0.31% ⛔
Sema.NumConformancesDeserialized 2062 2068 6 0.29% ⛔
Sema.NumLazyGenericEnvironments 3824 3830 6 0.16% ⛔
Improved (21)
Improved in Alamofire (3)
name old new delta delta_pct
Sema.NumLazyGenericEnvironments 27340 27303 -37 -0.14% ✅
Sema.NumConstraintScopes 39318 39204 -114 -0.29% ✅
Sema.NumLazyGenericEnvironmentsLoaded 2497 2397 -100 -4.0% ✅
Improved in Kingfisher (6)
name old new delta delta_pct
Sema.NumGenericSignatureBuilders 9642 9640 -2 -0.02% ✅
Sema.NumConstraintScopes 334228 334138 -90 -0.03% ✅
SILModule.NumSILGenFunctions 4178 4176 -2 -0.05% ✅
Sema.NumLazyGenericEnvironments 50914 50886 -28 -0.05% ✅
Sema.NumConformancesDeserialized 66935 66687 -248 -0.37% ✅
Sema.NumLazyGenericEnvironmentsLoaded 5280 5074 -206 -3.9% ✅
Improved in ReactiveCocoa (2)
name old new delta delta_pct
Sema.NumConstraintScopes 54820 54718 -102 -0.19% ✅
Sema.NumLazyGenericEnvironmentsLoaded 9152 8752 -400 -4.37% ✅
Improved in ReactiveSwift (8)
name old new delta delta_pct
IRModule.NumIRInsts 322023 321919 -104 -0.03% ✅
LLVM.NumLLVMBytesOutput 8419660 8417452 -2208 -0.03% ✅
IRModule.NumIRValueSymbols 19521 19505 -16 -0.08% ✅
Sema.NumConstraintScopes 36534 36506 -28 -0.08% ✅
IRModule.NumIRFunctions 10793 10777 -16 -0.15% ✅
SILModule.NumSILOptFunctions 7721 7709 -12 -0.16% ✅
IRModule.NumIRBasicBlocks 21190 21142 -48 -0.23% ✅
Sema.NumLazyGenericEnvironmentsLoaded 5886 5734 -152 -2.58% ✅
Improved in Result (2)
name old new delta delta_pct
Sema.NumConstraintScopes 3738 3734 -4 -0.11% ✅
Sema.NumLazyGenericEnvironmentsLoaded 486 470 -16 -3.29% ✅
Unchanged (abs(delta) < 0.01% or 100000usec) (61)
Unchanged (abs(delta) < 0.01% or 100000usec) in Alamofire (15)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 5727 5727 0 0.0%
AST.NumLoadedModules 522 522 0 0.0%
AST.NumTotalClangImportedEntities 18092 18092 0 0.0%
AST.NumUsedConformances 427 427 0 0.0%
IRModule.NumIRBasicBlocks 14722 14722 0 0.0%
IRModule.NumIRFunctions 5322 5322 0 0.0%
IRModule.NumIRGlobals 4660 4660 0 0.0%
IRModule.NumIRInsts 130247 130247 0 0.0%
IRModule.NumIRValueSymbols 8601 8601 0 0.0%
LLVM.NumLLVMBytesOutput 3079360 3079392 32 0.0%
SILModule.NumSILGenFunctions 2458 2458 0 0.0%
Sema.NumDeclsValidated 7138 7138 0 0.0%
Sema.NumFunctionsTypechecked 4043 4043 0 0.0%
Sema.NumGenericSignatureBuilders 3306 3306 0 0.0%
Sema.NumTypesValidated 6298 6298 0 0.0%
Unchanged (abs(delta) < 0.01% or 100000usec) in Kingfisher (7)
name old new delta delta_pct
IRModule.NumIRBasicBlocks 20377 20379 2 0.01%
AST.NumImportedExternalDefinitions 20024 20024 0 0.0%
AST.NumLoadedModules 1323 1323 0 0.0%
AST.NumTotalClangImportedEntities 56416 56416 0 0.0%
Sema.NumDeclsValidated 9306 9306 0 0.0%
Sema.NumFunctionsTypechecked 12594 12594 0 0.0%
Sema.NumTypesValidated 14214 14214 0 0.0%
Unchanged (abs(delta) < 0.01% or 100000usec) in ReactiveCocoa (15)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 32490 32490 0 0.0%
AST.NumLoadedModules 3536 3536 0 0.0%
AST.NumTotalClangImportedEntities 97352 97352 0 0.0%
AST.NumUsedConformances 672 672 0 0.0%
IRModule.NumIRBasicBlocks 12076 12076 0 0.0%
IRModule.NumIRFunctions 7123 7123 0 0.0%
IRModule.NumIRGlobals 9652 9652 0 0.0%
IRModule.NumIRInsts 101412 101412 0 0.0%
IRModule.NumIRValueSymbols 14773 14773 0 0.0%
LLVM.NumLLVMBytesOutput 6579740 6579756 16 0.0%
SILModule.NumSILGenFunctions 2892 2892 0 0.0%
Sema.NumDeclsValidated 4704 4704 0 0.0%
Sema.NumFunctionsTypechecked 17692 17692 0 0.0%
Sema.NumGenericSignatureBuilders 21664 21664 0 0.0%
Sema.NumTypesValidated 34130 34130 0 0.0%
Unchanged (abs(delta) < 0.01% or 100000usec) in ReactiveSwift (9)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 3394 3394 0 0.0%
AST.NumLoadedModules 880 880 0 0.0%
AST.NumTotalClangImportedEntities 8586 8586 0 0.0%
AST.NumUsedConformances 714 714 0 0.0%
IRModule.NumIRGlobals 12416 12416 0 0.0%
SILModule.NumSILGenFunctions 4813 4813 0 0.0%
Sema.NumDeclsValidated 20546 20546 0 0.0%
Sema.NumFunctionsTypechecked 3532 3532 0 0.0%
Sema.NumTypesValidated 70786 70786 0 0.0%
Unchanged (abs(delta) < 0.01% or 100000usec) in Result (15)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 334 334 0 0.0%
AST.NumLoadedModules 108 108 0 0.0%
AST.NumTotalClangImportedEntities 1064 1064 0 0.0%
AST.NumUsedConformances 62 62 0 0.0%
IRModule.NumIRBasicBlocks 1392 1392 0 0.0%
IRModule.NumIRFunctions 646 646 0 0.0%
IRModule.NumIRGlobals 754 754 0 0.0%
IRModule.NumIRInsts 17005 17005 0 0.0%
IRModule.NumIRValueSymbols 1182 1182 0 0.0%
LLVM.NumLLVMBytesOutput 405324 405324 0 0.0%
SILModule.NumSILGenFunctions 314 314 0 0.0%
Sema.NumDeclsValidated 516 516 0 0.0%
Sema.NumFunctionsTypechecked 298 298 0 0.0%
Sema.NumGenericSignatureBuilders 468 468 0 0.0%
Sema.NumTypesValidated 1184 1184 0 0.0%

PR vs. head, changed timers (debug)

Regressed (0)
Improved (0)
Unchanged (abs(delta) < 0.01% or 1000000usec) (9)
Unchanged (abs(delta) < 0.01% or 1000000usec) in Alamofire (1)
name old new delta delta_pct
time.swift-driver.Alamofire-all-x86_64_apple_macosx10.10-o-Onone.wall 5749870 5755560 5690 0.1%
Unchanged (abs(delta) < 0.01% or 1000000usec) in Kingfisher (2)
name old new delta delta_pct
time.swift-driver.Kingfisher-all-arm64_apple_ios8.0-o-Onone.wall 4821792 4841396 19604 0.41%
time.swift-driver.Kingfisher-all-armv7_apple_ios8.0-o-Onone.wall 5078808 4968421 -110387 -2.17%
Unchanged (abs(delta) < 0.01% or 1000000usec) in ReactiveCocoa (2)
name old new delta delta_pct
time.swift-driver.ReactiveCocoa-all-arm64_apple_ios8.0-o-Onone.wall 3391541 3368369 -23172 -0.68%
time.swift-driver.ReactiveCocoa-all-armv7_apple_ios8.0-o-Onone.wall 3416449 3380877 -35572 -1.04%
Unchanged (abs(delta) < 0.01% or 1000000usec) in ReactiveSwift (2)
name old new delta delta_pct
time.swift-driver.ReactiveSwift-all-arm64_apple_ios8.0-o-Onone.wall 3279603 3259834 -19769 -0.6%
time.swift-driver.ReactiveSwift-all-armv7_apple_ios8.0-o-Onone.wall 3348477 3328518 -19959 -0.6%
Unchanged (abs(delta) < 0.01% or 1000000usec) in Result (2)
name old new delta delta_pct
time.swift-driver.Result-all-arm64_apple_ios8.0-o-Onone.wall 1533786 1546299 12513 0.82%
time.swift-driver.Result-all-armv7_apple_ios8.0-o-Onone.wall 1541061 1541825 764 0.05%

PR vs. baseline (debug)

PR vs. baseline, changed counters (debug)

Regressed (16)
Regressed in Alamofire (3)
name old new delta delta_pct
SILModule.NumSILOptFunctions 3908 4754 846 21.65% ⛔
Sema.NumConformancesDeserialized 31066 34891 3825 12.31% ⛔
LLVM.NumLLVMBytesOutput 2995540 3079392 83852 2.8% ⛔
Regressed in Kingfisher (3)
name old new delta delta_pct
SILModule.NumSILOptFunctions 7512 8607 1095 14.58% ⛔
LLVM.NumLLVMBytesOutput 4701704 5071892 370188 7.87% ⛔
IRModule.NumIRBasicBlocks 18956 20379 1423 7.51% ⛔
Regressed in ReactiveCocoa (7)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 4775608 6579756 1804148 37.78% ⛔
Sema.NumConstraintScopes 42990 54718 11728 27.28% ⛔
SILModule.NumSILOptFunctions 4068 4378 310 7.62% ⛔
IRModule.NumIRBasicBlocks 11870 12076 206 1.74% ⛔
IRModule.NumIRGlobals 9536 9652 116 1.22% ⛔
IRModule.NumIRFunctions 7080 7123 43 0.61% ⛔
IRModule.NumIRValueSymbols 14686 14773 87 0.59% ⛔
Regressed in ReactiveSwift (3)
name old new delta delta_pct
SILModule.NumSILOptFunctions 6970 7709 739 10.6% ⛔
LLVM.NumLLVMBytesOutput 8049848 8417452 367604 4.57% ⛔
IRModule.NumIRGlobals 12388 12416 28 0.23% ⛔
Improved (72)
Improved in Alamofire (19)
name old new delta delta_pct
SILModule.NumSILGenFunctions 2463 2458 -5 -0.2% ✅
IRModule.NumIRFunctions 5357 5322 -35 -0.65% ✅
AST.NumUsedConformances 435 427 -8 -1.84% ✅
IRModule.NumIRValueSymbols 8767 8601 -166 -1.89% ✅
IRModule.NumIRGlobals 4765 4660 -105 -2.2% ✅
IRModule.NumIRBasicBlocks 15117 14722 -395 -2.61% ✅
Sema.NumDeclsDeserialized 193026 186454 -6572 -3.4% ✅
Sema.NumTypesDeserialized 158862 151910 -6952 -4.38% ✅
Sema.NumLazyGenericEnvironments 29740 27303 -2437 -8.19% ✅
Sema.NumLazyGenericEnvironmentsLoaded 2641 2397 -244 -9.24% ✅
Sema.NumConstraintScopes 43672 39204 -4468 -10.23% ✅
IRModule.NumIRInsts 145724 130247 -15477 -10.62% ✅
Sema.NumLazyIterableDeclContexts 21455 19075 -2380 -11.09% ✅
Sema.NumFunctionsTypechecked 5545 4043 -1502 -27.09% ✅
AST.NumImportedExternalDefinitions 8501 5727 -2774 -32.63% ✅
AST.NumTotalClangImportedEntities 27881 18092 -9789 -35.11% ✅
Sema.NumTypesValidated 18298 6298 -12000 -65.58% ✅
Sema.NumGenericSignatureBuilders 13996 3306 -10690 -76.38% ✅
Sema.NumDeclsValidated 61341 7138 -54203 -88.36% ✅
Improved in Kingfisher (19)
name old new delta delta_pct
SILModule.NumSILGenFunctions 4186 4176 -10 -0.24% ✅
IRModule.NumIRGlobals 9117 9043 -74 -0.81% ✅
IRModule.NumIRFunctions 8204 8135 -69 -0.84% ✅
AST.NumUsedConformances 858 850 -8 -0.93% ✅
IRModule.NumIRValueSymbols 14986 14815 -171 -1.14% ✅
Sema.NumConformancesDeserialized 70852 66687 -4165 -5.88% ✅
IRModule.NumIRInsts 194978 183370 -11608 -5.95% ✅
Sema.NumLazyGenericEnvironmentsLoaded 5480 5074 -406 -7.41% ✅
Sema.NumLazyIterableDeclContexts 54859 48767 -6092 -11.1% ✅
Sema.NumDeclsDeserialized 406573 343804 -62769 -15.44% ✅
Sema.NumTypesDeserialized 344515 283480 -61035 -17.72% ✅
Sema.NumLazyGenericEnvironments 65900 50886 -15014 -22.78% ✅
AST.NumTotalClangImportedEntities 75188 56416 -18772 -24.97% ✅
Sema.NumFunctionsTypechecked 17534 12594 -4940 -28.17% ✅
AST.NumImportedExternalDefinitions 28988 20024 -8964 -30.92% ✅
Sema.NumConstraintScopes 581970 334138 -247832 -42.59% ✅
Sema.NumTypesValidated 27944 14214 -13730 -49.13% ✅
Sema.NumGenericSignatureBuilders 33750 9640 -24110 -71.44% ✅
Sema.NumDeclsValidated 125016 9306 -115710 -92.56% ✅
Improved in ReactiveCocoa (15)
name old new delta delta_pct
SILModule.NumSILGenFunctions 2904 2892 -12 -0.41% ✅
IRModule.NumIRInsts 102753 101412 -1341 -1.31% ✅
AST.NumTotalClangImportedEntities 101754 97352 -4402 -4.33% ✅
Sema.NumFunctionsTypechecked 18516 17692 -824 -4.45% ✅
AST.NumUsedConformances 704 672 -32 -4.55% ✅
AST.NumImportedExternalDefinitions 34112 32490 -1622 -4.75% ✅
Sema.NumLazyIterableDeclContexts 105954 94792 -11162 -10.53% ✅
Sema.NumLazyGenericEnvironmentsLoaded 10174 8752 -1422 -13.98% ✅
Sema.NumConformancesDeserialized 57916 47594 -10322 -17.82% ✅
Sema.NumTypesDeserialized 447750 367789 -79961 -17.86% ✅
Sema.NumDeclsDeserialized 494670 399891 -94779 -19.16% ✅
Sema.NumLazyGenericEnvironments 90692 67190 -23502 -25.91% ✅
Sema.NumTypesValidated 49050 34130 -14920 -30.42% ✅
Sema.NumGenericSignatureBuilders 49468 21664 -27804 -56.21% ✅
Sema.NumDeclsValidated 106644 4704 -101940 -95.59% ✅
Improved in ReactiveSwift (19)
name old new delta delta_pct
SILModule.NumSILGenFunctions 4833 4813 -20 -0.41% ✅
IRModule.NumIRValueSymbols 19619 19505 -114 -0.58% ✅
IRModule.NumIRFunctions 10863 10777 -86 -0.79% ✅
AST.NumUsedConformances 730 714 -16 -2.19% ✅
IRModule.NumIRBasicBlocks 21814 21142 -672 -3.08% ✅
IRModule.NumIRInsts 332161 321919 -10242 -3.08% ✅
Sema.NumConformancesDeserialized 49822 48234 -1588 -3.19% ✅
Sema.NumConstraintScopes 41650 36506 -5144 -12.35% ✅
Sema.NumDeclsDeserialized 291790 245258 -46532 -15.95% ✅
Sema.NumTypesDeserialized 253286 209737 -43549 -17.19% ✅
Sema.NumLazyGenericEnvironments 50740 40454 -10286 -20.27% ✅
Sema.NumFunctionsTypechecked 4538 3532 -1006 -22.17% ✅
Sema.NumLazyGenericEnvironmentsLoaded 7646 5734 -1912 -25.01% ✅
Sema.NumLazyIterableDeclContexts 37546 27812 -9734 -25.93% ✅
Sema.NumTypesValidated 100770 70786 -29984 -29.75% ✅
AST.NumImportedExternalDefinitions 6434 3394 -3040 -47.25% ✅
AST.NumTotalClangImportedEntities 24796 8586 -16210 -65.37% ✅
Sema.NumGenericSignatureBuilders 31134 8842 -22292 -71.6% ✅
Sema.NumDeclsValidated 75348 20546 -54802 -72.73% ✅
Unchanged (abs(delta) < 0.01% or 100000usec) (4)
Unchanged (abs(delta) < 0.01% or 100000usec) in Alamofire (1)
name old new delta delta_pct
AST.NumLoadedModules 522 522 0 0.0%
Unchanged (abs(delta) < 0.01% or 100000usec) in Kingfisher (1)
name old new delta delta_pct
AST.NumLoadedModules 1323 1323 0 0.0%
Unchanged (abs(delta) < 0.01% or 100000usec) in ReactiveCocoa (1)
name old new delta delta_pct
AST.NumLoadedModules 3536 3536 0 0.0%
Unchanged (abs(delta) < 0.01% or 100000usec) in ReactiveSwift (1)
name old new delta delta_pct
AST.NumLoadedModules 880 880 0 0.0%

PR vs. baseline, changed timers (debug)

Regressed (0)
Improved (0)
Unchanged (abs(delta) < 0.01% or 1000000usec) (0)

Release

PR vs. head (release)

PR vs. head, changed counters (release)

Regressed (35)
Regressed in Alamofire (8)
name old new delta delta_pct
SILModule.NumSILOptFunctions 3071 3079 8 0.26% ⛔
IRModule.NumIRFunctions 3754 3763 9 0.24% ⛔
Sema.NumLazyIterableDeclContexts 1655 1659 4 0.24% ⛔
LLVM.NumLLVMBytesOutput 3396416 3401868 5452 0.16% ⛔
Sema.NumConformancesDeserialized 15607 15631 24 0.15% ⛔
IRModule.NumIRValueSymbols 7060 7069 9 0.13% ⛔
IRModule.NumIRBasicBlocks 15474 15482 8 0.05% ⛔
Sema.NumDeclsDeserialized 24212 24220 8 0.03% ⛔
Regressed in Kingfisher (7)
name old new delta delta_pct
AST.NumUsedConformances 842 850 8 0.95% ⛔
IRModule.NumIRFunctions 6116 6140 24 0.39% ⛔
Sema.NumLazyIterableDeclContexts 3527 3535 8 0.23% ⛔
IRModule.NumIRValueSymbols 13066 13089 23 0.18% ⛔
LLVM.NumLLVMBytesOutput 5991060 5999260 8200 0.14% ⛔
IRModule.NumIRBasicBlocks 23368 23392 24 0.1% ⛔
IRModule.NumIRInsts 157247 157279 32 0.02% ⛔
Regressed in ReactiveCocoa (7)
name old new delta delta_pct
Sema.NumLazyIterableDeclContexts 3778 3786 8 0.21% ⛔
SILModule.NumSILOptFunctions 3147 3153 6 0.19% ⛔
IRModule.NumIRFunctions 5009 5014 5 0.1% ⛔
Sema.NumConformancesDeserialized 20644 20660 16 0.08% ⛔
IRModule.NumIRBasicBlocks 8997 9001 4 0.04% ⛔
IRModule.NumIRValueSymbols 12230 12235 5 0.04% ⛔
Sema.NumDeclsDeserialized 41724 41740 16 0.04% ⛔
Regressed in ReactiveSwift (6)
name old new delta delta_pct
Sema.NumLazyIterableDeclContexts 2871 2879 8 0.28% ⛔
Sema.NumConformancesDeserialized 26629 26677 48 0.18% ⛔
IRModule.NumIRFunctions 10273 10287 14 0.14% ⛔
SILModule.NumSILOptFunctions 6928 6938 10 0.14% ⛔
IRModule.NumIRValueSymbols 19597 19609 12 0.06% ⛔
Sema.NumDeclsDeserialized 43989 44005 16 0.04% ⛔
Regressed in Result (7)
name old new delta delta_pct
Sema.NumLazyIterableDeclContexts 1962 1972 10 0.51% ⛔
Sema.NumDeclsDeserialized 22894 22984 90 0.39% ⛔
Sema.NumTypesDeserialized 19968 20036 68 0.34% ⛔
SILModule.NumSILOptFunctions 813 815 2 0.25% ⛔
Sema.NumConformancesDeserialized 4240 4250 10 0.24% ⛔
LLVM.NumLLVMBytesOutput 490100 490336 236 0.05% ⛔
Sema.NumLazyGenericEnvironments 3842 3844 2 0.05% ⛔
Improved (27)
Improved in Alamofire (4)
name old new delta delta_pct
IRModule.NumIRInsts 107611 107588 -23 -0.02% ✅
Sema.NumLazyGenericEnvironments 2668 2664 -4 -0.15% ✅
Sema.NumConstraintScopes 36195 36081 -114 -0.31% ✅
Sema.NumLazyGenericEnvironmentsLoaded 361 353 -8 -2.22% ✅
Improved in Kingfisher (8)
name old new delta delta_pct
SILModule.NumSILOptFunctions 5840 5838 -2 -0.03% ✅
Sema.NumConstraintScopes 323218 323128 -90 -0.03% ✅
Sema.NumDeclsDeserialized 48404 48386 -18 -0.04% ✅
Sema.NumGenericSignatureBuilders 1087 1085 -2 -0.18% ✅
Sema.NumLazyGenericEnvironments 4904 4884 -20 -0.41% ✅
Sema.NumTypesDeserialized 45214 44902 -312 -0.69% ✅
Sema.NumLazyGenericEnvironmentsLoaded 822 804 -18 -2.19% ✅
Sema.NumConformancesDeserialized 31642 30476 -1166 -3.68% ✅
Improved in ReactiveCocoa (5)
name old new delta delta_pct
Sema.NumTypesDeserialized 38761 38751 -10 -0.03% ✅
Sema.NumLazyGenericEnvironments 5952 5948 -4 -0.07% ✅
IRModule.NumIRInsts 65402 65346 -56 -0.09% ✅
Sema.NumConstraintScopes 37364 37262 -102 -0.27% ✅
Sema.NumLazyGenericEnvironmentsLoaded 692 676 -16 -2.31% ✅
Improved in ReactiveSwift (8)
name old new delta delta_pct
IRModule.NumIRGlobals 11626 11624 -2 -0.02% ✅
Sema.NumTypesDeserialized 39471 39461 -10 -0.03% ✅
IRModule.NumIRInsts 260109 259922 -187 -0.07% ✅
LLVM.NumLLVMBytesOutput 10135440 10127068 -8372 -0.08% ✅
Sema.NumConstraintScopes 34928 34900 -28 -0.08% ✅
IRModule.NumIRBasicBlocks 22032 21998 -34 -0.15% ✅
Sema.NumLazyGenericEnvironments 4936 4928 -8 -0.16% ✅
Sema.NumLazyGenericEnvironmentsLoaded 810 794 -16 -1.98% ✅
Improved in Result (2)
name old new delta delta_pct
Sema.NumConstraintScopes 3736 3732 -4 -0.11% ✅
Sema.NumLazyGenericEnvironmentsLoaded 338 330 -8 -2.37% ✅
Unchanged (abs(delta) < 0.01% or 100000usec) (53)
Unchanged (abs(delta) < 0.01% or 100000usec) in Alamofire (11)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 881 881 0 0.0%
AST.NumLoadedModules 28 28 0 0.0%
AST.NumTotalClangImportedEntities 3234 3234 0 0.0%
AST.NumUsedConformances 427 427 0 0.0%
IRModule.NumIRGlobals 4435 4435 0 0.0%
SILModule.NumSILGenFunctions 1860 1860 0 0.0%
Sema.NumDeclsValidated 3283 3283 0 0.0%
Sema.NumFunctionsTypechecked 1104 1104 0 0.0%
Sema.NumGenericSignatureBuilders 416 416 0 0.0%
Sema.NumTypesDeserialized 22917 22916 -1 -0.0%
Sema.NumTypesValidated 1592 1592 0 0.0%
Unchanged (abs(delta) < 0.01% or 100000usec) in Kingfisher (8)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 3368 3368 0 0.0%
AST.NumLoadedModules 61 61 0 0.0%
AST.NumTotalClangImportedEntities 9816 9816 0 0.0%
SILModule.NumSILGenFunctions 3056 3056 0 0.0%
Sema.NumDeclsValidated 4144 4144 0 0.0%
Sema.NumFunctionsTypechecked 2848 2848 0 0.0%
Sema.NumTypesValidated 2740 2740 0 0.0%
IRModule.NumIRGlobals 8552 8551 -1 -0.01%
Unchanged (abs(delta) < 0.01% or 100000usec) in ReactiveCocoa (11)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 8823716 8825024 1308 0.01%
AST.NumImportedExternalDefinitions 3132 3132 0 0.0%
AST.NumLoadedModules 66 66 0 0.0%
AST.NumTotalClangImportedEntities 7434 7434 0 0.0%
AST.NumUsedConformances 672 672 0 0.0%
IRModule.NumIRGlobals 8487 8487 0 0.0%
SILModule.NumSILGenFunctions 1913 1913 0 0.0%
Sema.NumDeclsValidated 2398 2398 0 0.0%
Sema.NumFunctionsTypechecked 2482 2482 0 0.0%
Sema.NumGenericSignatureBuilders 1282 1282 0 0.0%
Sema.NumTypesValidated 2372 2372 0 0.0%
Unchanged (abs(delta) < 0.01% or 100000usec) in ReactiveSwift (9)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 512 512 0 0.0%
AST.NumLoadedModules 38 38 0 0.0%
AST.NumTotalClangImportedEntities 2102 2102 0 0.0%
AST.NumUsedConformances 720 720 0 0.0%
SILModule.NumSILGenFunctions 3735 3735 0 0.0%
Sema.NumDeclsValidated 7570 7570 0 0.0%
Sema.NumFunctionsTypechecked 1976 1976 0 0.0%
Sema.NumGenericSignatureBuilders 1515 1515 0 0.0%
Sema.NumTypesValidated 23594 23594 0 0.0%
Unchanged (abs(delta) < 0.01% or 100000usec) in Result (14)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 316 316 0 0.0%
AST.NumLoadedModules 34 34 0 0.0%
AST.NumTotalClangImportedEntities 1300 1300 0 0.0%
AST.NumUsedConformances 62 62 0 0.0%
IRModule.NumIRBasicBlocks 2118 2118 0 0.0%
IRModule.NumIRFunctions 644 644 0 0.0%
IRModule.NumIRGlobals 683 683 0 0.0%
IRModule.NumIRInsts 19449 19449 0 0.0%
IRModule.NumIRValueSymbols 1211 1211 0 0.0%
SILModule.NumSILGenFunctions 292 292 0 0.0%
Sema.NumDeclsValidated 470 470 0 0.0%
Sema.NumFunctionsTypechecked 296 296 0 0.0%
Sema.NumGenericSignatureBuilders 368 368 0 0.0%
Sema.NumTypesValidated 990 990 0 0.0%

PR vs. head, changed timers (release)

Regressed (0)
Improved (0)
Unchanged (abs(delta) < 0.01% or 1000000usec) (9)
Unchanged (abs(delta) < 0.01% or 1000000usec) in Alamofire (1)
name old new delta delta_pct
time.swift-driver.Alamofire-all-x86_64_apple_macosx10.10-o-O.wall 10519290 10574790 55500 0.53%
Unchanged (abs(delta) < 0.01% or 1000000usec) in Kingfisher (2)
name old new delta delta_pct
time.swift-driver.Kingfisher-all-arm64_apple_ios8.0-o-O.wall 10952440 11062020 109580 1.0%
time.swift-driver.Kingfisher-all-armv7_apple_ios8.0-o-O.wall 11206930 11205300 -1630 -0.01%
Unchanged (abs(delta) < 0.01% or 1000000usec) in ReactiveCocoa (2)
name old new delta delta_pct
time.swift-driver.ReactiveCocoa-all-arm64_apple_ios8.0-o-O.wall 4990408 5015797 25389 0.51%
time.swift-driver.ReactiveCocoa-all-armv7_apple_ios8.0-o-O.wall 4976171 4994300 18129 0.36%
Unchanged (abs(delta) < 0.01% or 1000000usec) in ReactiveSwift (2)
name old new delta delta_pct
time.swift-driver.ReactiveSwift-all-armv7_apple_ios8.0-o-O.wall 10641220 10682370 41150 0.39%
time.swift-driver.ReactiveSwift-all-arm64_apple_ios8.0-o-O.wall 10482730 10434210 -48520 -0.46%
Unchanged (abs(delta) < 0.01% or 1000000usec) in Result (2)
name old new delta delta_pct
time.swift-driver.Result-all-arm64_apple_ios8.0-o-O.wall 2729062 2737456 8394 0.31%
time.swift-driver.Result-all-armv7_apple_ios8.0-o-O.wall 2775236 2774765 -471 -0.02%

PR vs. baseline (release)

PR vs. baseline, changed counters (release)

Regressed (12)
Regressed in Alamofire (3)
name old new delta delta_pct
AST.NumTotalClangImportedEntities 2920 3234 314 10.75% ⛔
LLVM.NumLLVMBytesOutput 3172156 3401868 229712 7.24% ⛔
SILModule.NumSILOptFunctions 2991 3079 88 2.94% ⛔
Regressed in Kingfisher (3)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 5462712 5999260 536548 9.82% ⛔
AST.NumTotalClangImportedEntities 9086 9816 730 8.03% ⛔
SILModule.NumSILOptFunctions 5723 5838 115 2.01% ⛔
Regressed in ReactiveCocoa (4)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 5480320 8825024 3344704 61.03% ⛔
Sema.NumConstraintScopes 23810 37262 13452 56.5% ⛔
SILModule.NumSILOptFunctions 2915 3153 238 8.16% ⛔
AST.NumTotalClangImportedEntities 7270 7434 164 2.26% ⛔
Regressed in ReactiveSwift (2)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 9452416 10127068 674652 7.14% ⛔
SILModule.NumSILOptFunctions 6852 6938 86 1.26% ⛔
Improved (70)
Improved in Alamofire (17)
name old new delta delta_pct
SILModule.NumSILGenFunctions 1861 1860 -1 -0.05% ✅
IRModule.NumIRFunctions 3819 3763 -56 -1.47% ✅
AST.NumUsedConformances 435 427 -8 -1.84% ✅
IRModule.NumIRGlobals 4521 4435 -86 -1.9% ✅
IRModule.NumIRValueSymbols 7218 7069 -149 -2.06% ✅
Sema.NumDeclsDeserialized 24875 24220 -655 -2.63% ✅
Sema.NumLazyIterableDeclContexts 1716 1659 -57 -3.32% ✅
Sema.NumTypesDeserialized 23832 22916 -916 -3.84% ✅
Sema.NumConformancesDeserialized 16433 15631 -802 -4.88% ✅
Sema.NumLazyGenericEnvironments 2814 2664 -150 -5.33% ✅
Sema.NumConstraintScopes 38683 36081 -2602 -6.73% ✅
Sema.NumLazyGenericEnvironmentsLoaded 383 353 -30 -7.83% ✅
IRModule.NumIRBasicBlocks 16869 15482 -1387 -8.22% ✅
IRModule.NumIRInsts 123248 107588 -15660 -12.71% ✅
Sema.NumTypesValidated 1977 1592 -385 -19.47% ✅
Sema.NumGenericSignatureBuilders 1595 416 -1179 -73.92% ✅
Sema.NumDeclsValidated 17283 3283 -14000 -81.0% ✅
Improved in Kingfisher (16)
name old new delta delta_pct
IRModule.NumIRGlobals 8627 8551 -76 -0.88% ✅
AST.NumUsedConformances 858 850 -8 -0.93% ✅
Sema.NumConformancesDeserialized 30795 30476 -319 -1.04% ✅
Sema.NumDeclsDeserialized 48980 48386 -594 -1.21% ✅
IRModule.NumIRValueSymbols 13308 13089 -219 -1.65% ✅
IRModule.NumIRFunctions 6265 6140 -125 -2.0% ✅
Sema.NumTypesDeserialized 46208 44902 -1306 -2.83% ✅
Sema.NumLazyIterableDeclContexts 3642 3535 -107 -2.94% ✅
Sema.NumLazyGenericEnvironments 5174 4884 -290 -5.6% ✅
IRModule.NumIRBasicBlocks 25356 23392 -1964 -7.75% ✅
Sema.NumLazyGenericEnvironmentsLoaded 876 804 -72 -8.22% ✅
IRModule.NumIRInsts 189828 157279 -32549 -17.15% ✅
Sema.NumTypesValidated 3794 2740 -1054 -27.78% ✅
Sema.NumConstraintScopes 564928 323128 -241800 -42.8% ✅
Sema.NumGenericSignatureBuilders 3925 1085 -2840 -72.36% ✅
Sema.NumDeclsValidated 35702 4144 -31558 -88.39% ✅
Improved in ReactiveCocoa (17)
name old new delta delta_pct
Sema.NumFunctionsTypechecked 2484 2482 -2 -0.08% ✅
AST.NumImportedExternalDefinitions 3138 3132 -6 -0.19% ✅
SILModule.NumSILGenFunctions 1917 1913 -4 -0.21% ✅
IRModule.NumIRValueSymbols 12322 12235 -87 -0.71% ✅
Sema.NumConformancesDeserialized 20926 20660 -266 -1.27% ✅
IRModule.NumIRFunctions 5090 5014 -76 -1.49% ✅
Sema.NumDeclsDeserialized 42739 41740 -999 -2.34% ✅
Sema.NumLazyIterableDeclContexts 3880 3786 -94 -2.42% ✅
Sema.NumTypesDeserialized 39750 38751 -999 -2.51% ✅
Sema.NumLazyGenericEnvironments 6210 5948 -262 -4.22% ✅
AST.NumUsedConformances 704 672 -32 -4.55% ✅
IRModule.NumIRBasicBlocks 9437 9001 -436 -4.62% ✅
IRModule.NumIRInsts 69895 65346 -4549 -6.51% ✅
Sema.NumLazyGenericEnvironmentsLoaded 728 676 -52 -7.14% ✅
Sema.NumTypesValidated 4072 2372 -1700 -41.75% ✅
Sema.NumGenericSignatureBuilders 3612 1282 -2330 -64.51% ✅
Sema.NumDeclsValidated 20206 2398 -17808 -88.13% ✅
Improved in ReactiveSwift (20)
name old new delta delta_pct
IRModule.NumIRGlobals 11628 11624 -4 -0.03% ✅
SILModule.NumSILGenFunctions 3755 3735 -20 -0.53% ✅
Sema.NumConformancesDeserialized 26845 26677 -168 -0.63% ✅
Sema.NumFunctionsTypechecked 1990 1976 -14 -0.7% ✅
AST.NumUsedConformances 732 720 -12 -1.64% ✅
IRModule.NumIRValueSymbols 19993 19609 -384 -1.92% ✅
Sema.NumDeclsDeserialized 44930 44005 -925 -2.06% ✅
IRModule.NumIRFunctions 10605 10287 -318 -3.0% ✅
Sema.NumLazyIterableDeclContexts 2982 2879 -103 -3.45% ✅
Sema.NumTypesDeserialized 40957 39461 -1496 -3.65% ✅
IRModule.NumIRInsts 271570 259922 -11648 -4.29% ✅
Sema.NumLazyGenericEnvironments 5196 4928 -268 -5.16% ✅
IRModule.NumIRBasicBlocks 23918 21998 -1920 -8.03% ✅
Sema.NumConstraintScopes 38598 34900 -3698 -9.58% ✅
Sema.NumTypesValidated 26352 23594 -2758 -10.47% ✅
Sema.NumLazyGenericEnvironmentsLoaded 890 794 -96 -10.79% ✅
AST.NumImportedExternalDefinitions 592 512 -80 -13.51% ✅
AST.NumTotalClangImportedEntities 2670 2102 -568 -21.27% ✅
Sema.NumGenericSignatureBuilders 4390 1515 -2875 -65.49% ✅
Sema.NumDeclsValidated 28656 7570 -21086 -73.58% ✅
Unchanged (abs(delta) < 0.01% or 100000usec) (10)
Unchanged (abs(delta) < 0.01% or 100000usec) in Alamofire (3)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 881 881 0 0.0%
AST.NumLoadedModules 28 28 0 0.0%
Sema.NumFunctionsTypechecked 1104 1104 0 0.0%
Unchanged (abs(delta) < 0.01% or 100000usec) in Kingfisher (4)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 3368 3368 0 0.0%
AST.NumLoadedModules 61 61 0 0.0%
SILModule.NumSILGenFunctions 3056 3056 0 0.0%
Sema.NumFunctionsTypechecked 2848 2848 0 0.0%
Unchanged (abs(delta) < 0.01% or 100000usec) in ReactiveCocoa (2)
name old new delta delta_pct
IRModule.NumIRGlobals 8486 8487 1 0.01%
AST.NumLoadedModules 66 66 0 0.0%
Unchanged (abs(delta) < 0.01% or 100000usec) in ReactiveSwift (1)
name old new delta delta_pct
AST.NumLoadedModules 38 38 0 0.0%

PR vs. baseline, changed timers (release)

Regressed (0)
Improved (0)
Unchanged (abs(delta) < 0.01% or 1000000usec) (0)
Last baseline commit on smoketest-master-debug.csv 
commit 051207462e73c88493bbf2e49795efb88cb6c1ec
Author: Graydon Hoare 
Date:   Tue Oct 10 12:33:02 2017 -0700

    Update smoketest baselines for Swift version 4.0.1-dev (LLVM 2dedb62a0b, Clang ab7472e733, Swift 866e511daa)

Last baseline commit on smoketest-master-release.csv

commit 051207462e73c88493bbf2e49795efb88cb6c1ec
Author: Graydon Hoare 
Date:   Tue Oct 10 12:33:02 2017 -0700

    Update smoketest baselines for Swift version 4.0.1-dev (LLVM 2dedb62a0b, Clang ab7472e733, Swift 866e511daa)

@DougGregor
Copy link
Member

I'm taking this over in #12910, and it's really, really close

@DougGregor DougGregor closed this Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavapestov slavapestov slavapestov left review comments

@moiseev moiseev Awaiting requested review from moiseev

@airspeedswift airspeedswift Awaiting requested review from airspeedswift

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@huonw @moiseev @swift-ci @DougGregor @slavapestov