[DiagnosticsQoI] Refactor ArrayExpr visitor for better QoI #13471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove mention of the word “contextual” type from the diagnostic that rewrites array literals into dictionary literals and scale back the scope of the diagnostic. This method was catching and mis-diagnosing too many errors that could better be handled by invalid conversion diagnostics.
|
@swift-ci please smoke test |
|
Better than what we have! 👍 |
|
None of the test cases are exactly what's in the Jira though, or did I miss one? |
|
I didn't solve your particular issue with this patch, so I'm going to save it for later. |
|
@CodaFi gotcha, thanks for improving this though 👍 |
xedin
approved these changes
Dec 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SR-6623 inspired me to take look around here and clean it up. The diff is a mess, but the changes in diagnostics in the existing tests are indicative of the improvements the patch provides.