[Parse] Refactor Lexer's skipToEndOfline #13495
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lexer
has two similar methods which areskipToEndOfLine
andskipUpToEndOfLine
.This PR unify them.
The only difference in them are that
it will stop at which before or after of newline found,
so add
EatNewline
parameter to function to control this.And because of this behavior about newline,
lexTrivia
does not reuseskipSlashSlashComment
andskipHashbang
.So add
EatNewline
to them, use in common fromlexTrivia
This PR includes my other PR #13483