Fix closure capture boxes regression #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jckarter Can you please review for 2.2? |
|
@swift-ci Please test |
|
Looks good. Thanks for catching this! |
This is broken in Swift 2.2 and was only fixed in master. It looks like passing of the interface type into type lowering was introduced by this commit from a recent redesign of closure captures: apple@b76c0ab Fixes <rdar://problem/24470533>, which is part of <https://bugs.swift.org/browse/SR-661>.
This is one of the reductions from <https://bugs.swift.org/browse/SR-661>.
slavapestov
force-pushed
the
fix-closure-capture-boxes-regression-2.2
branch
from
d8e2dd3
to
6a0cc67
Compare
|
I added a SILGen test. |
|
@swift-ci Please test |
slavapestov
added a commit
that referenced
this pull request
Feb 19, 2016
…egression-2.2 Fix closure capture boxes regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is broken in Swift 2.2 and was only fixed in master. It looks like
passing of the interface type into type lowering was introduced by this
commit from a recent redesign of closure captures:
b76c0ab
Fixes rdar://problem/24470533.