Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IRGen support for coroutines #13788

Merged
merged 2 commits into from Jan 9, 2018
Merged

IRGen support for coroutines #13788

merged 2 commits into from Jan 9, 2018

Conversation

rjmccall
Copy link
Member

@rjmccall rjmccall commented Jan 7, 2018 •
edited

Implement basic IRGen support for coroutines and enough optimizer support to actually generate optimized and unoptimized code from the SIL test cases in this patch.

Optimization seems to break it sometimes, but I'll land this first.

@rjmccall
Copy link
Member Author

rjmccall commented Jan 7, 2018

@swift-ci Please test.

@swift-ci
Copy link
Collaborator

swift-ci commented Jan 7, 2018

Build failed
Swift Test OS X Platform
Git Sha - 3ad2049895874d360643cd56a6a8f4d05eebdac0

@rjmccall
Copy link
Member Author

rjmccall commented Jan 7, 2018

Oh, ha, I forgot that I haven't checked that in.

@rjmccall
Copy link
Member Author

rjmccall commented Jan 7, 2018

@swift-ci Please test.

@swift-ci
Copy link
Collaborator

swift-ci commented Jan 7, 2018

Build failed
Swift Test OS X Platform
Git Sha - 3ad2049895874d360643cd56a6a8f4d05eebdac0

@rjmccall
Copy link
Member Author

rjmccall commented Jan 7, 2018

I see, I need to wait until stable is automerged from swift-4.1-branch.

@swift-ci
Copy link
Collaborator

swift-ci commented Jan 7, 2018

Build failed
Swift Test Linux Platform
Git Sha - 3ad2049895874d360643cd56a6a8f4d05eebdac0

@rjmccall
Copy link
Member Author

rjmccall commented Jan 7, 2018

@swift-ci Please test.

1 similar comment
@rjmccall
Copy link
Member Author

rjmccall commented Jan 7, 2018

@swift-ci Please test.

@swift-ci
Copy link
Collaborator

swift-ci commented Jan 7, 2018

Build failed
Swift Test Linux Platform
Git Sha - 3ad2049895874d360643cd56a6a8f4d05eebdac0

@swift-ci
Copy link
Collaborator

swift-ci commented Jan 7, 2018

Build failed
Swift Test OS X Platform
Git Sha - 3ad2049895874d360643cd56a6a8f4d05eebdac0

@rjmccall
Make it easier to define an ExternalUnion where the kind type is
b80808b 
just used to select the union storage, rather than having any
external meaning.
@rjmccall rjmccall force-pushed the coro-irgen branch 2 times, most recently from 2c5bdee to ef5d128 Compare January 9, 2018 07:01
@rjmccall
Copy link
Member Author

rjmccall commented Jan 9, 2018

@swift-ci Please test.

@swift-ci
Copy link
Collaborator

swift-ci commented Jan 9, 2018

Build failed
Swift Test OS X Platform
Git Sha - 3ad2049895874d360643cd56a6a8f4d05eebdac0

@swift-ci
Copy link
Collaborator

swift-ci commented Jan 9, 2018

Build failed
Swift Test Linux Platform
Git Sha - 3ad2049895874d360643cd56a6a8f4d05eebdac0

@rjmccall
Copy link
Member Author

rjmccall commented Jan 9, 2018

One test doesn't work on i386 because the scalar return limit is lower. It's easiest to just make the test UNSUPPORTED on that target.

@rjmccall
Copy link
Member Author

rjmccall commented Jan 9, 2018

@swift-ci Please smoke test and merge.

1 similar comment
@rjmccall
Copy link
Member Author

rjmccall commented Jan 9, 2018

@swift-ci Please smoke test and merge.

@swift-ci swift-ci merged commit f44ff6c into apple:master Jan 9, 2018
@rjmccall rjmccall deleted the coro-irgen branch January 9, 2018 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rjmccall @swift-ci