Bump the compiler version to 5.0 (and compat versions 4.2 and 3.4) #13843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrose-apple
commented
Jan 10, 2018
| @@ -145,7 +145,7 @@ bb0(%0 : $*AnyObject): | |||
| // CHECK: store [[TMP]] to %0 : $*Optional<AnyObject> | |||
| sil @testIOU : $@convention(thin) (@in Optional<AnyObject>) -> (@out Optional<AnyObject>) { | |||
| bb0(%0 : $*Optional<AnyObject>, %1: $*Optional<AnyObject>): | |||
| unconditional_checked_cast_addr ImplicitlyUnwrappedOptional<AnyObject> in %1 : $*Optional<AnyObject> to Optional<AnyObject> in %0 : $*Optional<AnyObject> | |||
| unconditional_checked_cast_addr Swift.ImplicitlyUnwrappedOptional<AnyObject> in %1 : $*Optional<AnyObject> to Optional<AnyObject> in %0 : $*Optional<AnyObject> | |||
There was a problem hiding this comment.
@rudkx This was a hack to keep this test doing what it's doing, but it's not supposed to work, is it? What if someone's doing this in regular Swift code?
There was a problem hiding this comment.
Ah, it looks like this busts the parse_stdlib tests too. I'm going to remove the restriction on mentioning IUO by name in SIL mode instead, but you still might want to look at this for non-SIL mode.
|
@swift-ci Please test |
|
Build failed |
|
Closing per https://swift.org/blog/4-2-release-process/ – we'll be doing a 4.2 before we do 5.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #13767 where we jump all the way to 5.0 now.