SILGen: Support multiple-entry case blocks with address-only bindings #13988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Getting there... |
slavapestov
force-pushed
the
address-only-switch
branch
3 times, most recently
from
a6d612a
to
fe902b1
Compare
slavapestov
changed the title
slavapestov
force-pushed
the
address-only-switch
branch
3 times, most recently
from
7751712
to
7876ac8
Compare
|
@swift-ci Please smoke test |
slavapestov
force-pushed
the
address-only-switch
branch
from
7876ac8
to
0a54208
Compare
|
I think this also ought to fix https://bugs.swift.org/browse/SR-2555 - I'll tie those two bugs together as related. |
|
@gregomni Thanks! That's the same exact bug, just the example uses generic parameters and not existentials. I'll close both out when I merge this. |
slavapestov
force-pushed
the
address-only-switch
branch
from
36b6216
to
e453477
Compare
Fixes <rdar://problem/30870493>, <https://bugs.swift.org/browse/SR-4163>.
This reverts commit bbb21c8.
slavapestov
force-pushed
the
address-only-switch
branch
from
e453477
to
162187c
Compare
slavapestov
changed the title
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
|
Build failed |
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
This was referenced Jan 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://problem/27863650, rdar://problem/28170927, https://bugs.swift.org/browse/SR-2555, rdar://problem/30870493, https://bugs.swift.org/browse/SR-4163.