Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIL : Use the enum 's generic signature and the payloads type for an … #14215

Merged

Conversation

aschwaighofer
Copy link
Member

…indirect enum payload's box type.

i.e for:

enum Indirect<T> {
  indirect cast payload(first: T, second :T)
}

let _ = Indirect<X>

The payload's SIL box type will be:

$<t_0_0> { var (first: t_0_0, second: t_0_0) } <X>

rdar: //36799330

…indirect enum payload's box type.

i.e for:

enum Indirect<T> {
  indirect cast payload(first: T, second :T)
}

let _ = Indirect<X>

The payload's SIL box type will be:

$<t_0_0> { var (first: t_0_0, second: t_0_0) } <X>

rdar: //36799330
@aschwaighofer
Copy link
Member Author

@swift-ci Please test

@aschwaighofer
Copy link
Member Author

@swift-ci Please test source compatibility

@aschwaighofer
Copy link
Member Author

@rjmccall John is that what you had in mind?

@swift-ci
Copy link
Collaborator

Build failed
Swift Test Linux Platform
Git Sha - fac09e9

@aschwaighofer
Copy link
Member Author

@swift-ci Please smoke test linux

@aschwaighofer
Copy link
Member Author

@swift-ci Please test linux

@aschwaighofer
Copy link
Member Author

The source compat tests also currently fail on master e.g.:

fatal: unable to access 'https://github.com/vapor/crypto.git/': error setting certificate verify locations:
  CAfile: /etc/ssl/cert.pem
  CApath: none

@aschwaighofer aschwaighofer merged commit fbdcee4 into apple:master Jan 29, 2018
@rjmccall
Copy link
Member

Yes, that looks exactly right, thanks! I'm glad it worked out so easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants