SwiftSyntax: add a mechanism to define traits of syntax nodes to allow abstract access to popular child kinds. NFC #14668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w abstract access to popular child kinds. NFC Swift syntax APIs lack an abstract way of accessing children. The client has to down-cast a syntax node to the leaf type to access any of its children. However, some children are common among different syntax kinds, e.g. DeclAttributeSyntax and DeclMembers. We should allow an abstract way to access and modify them, so that clients can avoid logic duplication. This patch adds a mechanism to define new traits and specify satisfied traits in specific syntax nodes. A trait is a set of common children and implemented in Swift as a protocol for syntax nodes to conform to. As a proof-of-concept, we added two traits for now including DeclGroup and BracedSyntax. Resolves: SR-6931 and SR-6916
|
@swift-ci please smoke test |
nkcsgexi
changed the title
harlanhaskins
approved these changes
Feb 15, 2018
utils/gyb_syntax_support/Traits.py
Outdated
| from Child import Child | ||
|
|
||
|
|
||
| class TRAIT(object): |
There was a problem hiding this comment.
Nitpick: Trait in title case, please.
|
@swift-ci please smoke test |
rintaro
reviewed
Feb 15, 2018
utils/gyb_syntax_support/Traits.py
Outdated
|
|
||
|
|
||
| TRAITS = [ | ||
| Trait('DeclGroup', |
There was a problem hiding this comment.
I think traits should also be postfixed with "Syntax".
Could you make this DeclGroupSyntax?
Or make them DeclGroup and Braced, and postfix in the client?
public protocol ${trait.trait_name}Syntax {There was a problem hiding this comment.
Sure, I will rename this to DeclGroupSyntax.
|
@swift-ci please smoke test |
maldahleh
pushed a commit
to maldahleh/swift
that referenced
this pull request
Oct 26, 2020
…w abstract access to popular child kinds. NFC (apple#14668) Swift syntax APIs lack an abstract way of accessing children. The client has to down-cast a syntax node to the leaf type to access any of its children. However, some children are common among different syntax kinds, e.g. DeclAttributeSyntax and DeclMembers. We should allow an abstract way to access and modify them, so that clients can avoid logic duplication. This patch adds a mechanism to define new traits and specify satisfied traits in specific syntax nodes. A trait is a set of common children and implemented in Swift as a protocol for syntax nodes to conform to. As a proof-of-concept, we added two traits for now including DeclGroupSyntax and BracedSyntax. Resolves: SR-6931 and SR-6916
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift syntax APIs lack an abstract way of accessing children. The client has to
down-cast a syntax node to the leaf type to access any of its children. However,
some children are common among different syntax kinds, e.g.
DeclAttributeSyntax and DeclMembers. We should allow an abstract way to
access and modify them, so that clients can avoid logic duplication.
This patch adds a mechanism to define new traits and specify satisfied
traits in specific syntax nodes. A trait is a set of common children
and implemented in Swift as a protocol for syntax nodes to conform to.
As a proof-of-concept, we added two traits for now including DeclGroup
and BracedSyntax.
Resolves: #49479 and #49465