[Syntax] Parse 'switch' statement #15537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
harlanhaskins
approved these changes
Mar 27, 2018
| Child('Elements', kind='Syntax', | ||
| node_choices=[ | ||
| Child('Statements', kind='CodeBlockItemList'), | ||
| Child('SwitchCases', kind='SwitchCaseList')]), |
There was a problem hiding this comment.
I wonder if there’s anything we could do to try to merge these
rintaro
commented
Mar 27, 2018
| Child('Elements', kind='Syntax', | ||
| node_choices=[ | ||
| Child('Statements', kind='CodeBlockItemList'), | ||
| Child('SwitchCases', kind='SwitchCaseList')]), |
There was a problem hiding this comment.
Dropping WithStatements trait from IfConfigDecl.
But separating IfConfigDecl only for switch-cases (i.e. SwitchCaseIfConfig) doesn't seem the right choice.
|
@swift-ci Please smoke test |
|
Can you also update |
rintaro
force-pushed
the
syntax-parse-switch
branch
from
62b8054
to
4488e99
Compare
|
@swift-ci Please smoke test |
nkcsgexi
approved these changes
Mar 27, 2018
|
Ah, please make sure I remember to update this after #14382 goes in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #49466
CC: @nkcsgexi @harlanhaskins