Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove needless equal symbol in max func #156

Closed
wants to merge 1 commit into from
Closed

Remove needless equal symbol in max func #156

wants to merge 1 commit into from

Conversation

ken0nek
Copy link
Contributor

@ken0nek ken0nek commented Dec 4, 2015

I think that this equal symbol is not necessary like min func.

@ken0nek ken0nek changed the title Remove needless equal symbol of max func Remove needless equal symbol in max func Dec 4, 2015
@gribozavr
Copy link
Collaborator

Could you take a look at the discussion in pull request #137? There's a good direction that we discovered there. Please also add tests. The tests should go into validation-test/stdlib/Algorithm.swift, and use MinimalComparableValue from StdlibUnittest.

@ken0nek
Copy link
Contributor Author

ken0nek commented Dec 4, 2015

oh there is already the same topic..
@gribozavr I should close this pull req and continue discussing in pull req #137

@ken0nek ken0nek closed this Dec 4, 2015
dabelknap pushed a commit to dabelknap/swift that referenced this pull request Nov 27, 2018
Wrap `if case .foo = bar` pattern matching expressions.
maldahleh pushed a commit to maldahleh/swift that referenced this pull request Oct 26, 2020
[SyntaxParse] Revert syntax parsing changes from the master branch
freak4pc pushed a commit to freak4pc/swift that referenced this pull request Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants