IRGen: fix a wrong tail-call attribute in a partial apply forwarder #15829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an alloca'd memory is passed to a function it must not be a tail call, because otherwise llvm's dead store elimination would eliminate all stores to it. rdar://problem/39250070
|
@swift-ci smoke test and merge |
|
Nice catch! For the master branch, can you maybe factor out a wrapper around createAllocas that sets needsAllocas to true, so that we don't forget to do it anywhere else? |
|
@swift-ci smoke test macOS |
|
@slavapestov I experimented a bit but it turned out to be not so easy, because some alloca's are created in nested functions and not all alloca's are relevant for this check (because the memory is not actually used in the call). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an alloca'd memory is passed to a function it must not be a tail call, because otherwise llvm's dead store elimination would eliminate all stores to it.
rdar://problem/39250070