[Sema] Explicit error for "extension GenericClass : ObjcProtocol". #15842
Conversation
|
@swift-ci please smoke test |
include/swift/AST/Types.h
Outdated
| /// | ||
| /// \returns The closest superclass of this type that has generic parameters, | ||
| /// including the type itself, or null if none exists. | ||
| Type getLowestGenericClassInHierarchy(); |
There was a problem hiding this comment.
I like the term "closest" that you used in comments better than "lowest", because I've seen people write inheritance in both directions and wouldn't necessarily know which "lower" we're talking about.
There was a problem hiding this comment.
I ended up changing it to "getGenericAncestor" on @slavapestov's suggestion, since it covers slightly more than generic classes:
class Outer<T> { class Inner {} }
class ThisShouldAlsoBeFlagged: Outer<Int>.Inner {}
huonw
force-pushed
the
generic-class-objc-protocol-extension
branch
from
d8f7e7d
to
df2db66
Compare
|
@swift-ci please smoke test |
|
@swift-ci smoke test. |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test. |
huonw
force-pushed
the
generic-class-objc-protocol-extension
branch
from
df2db66
to
5da5eb0
Compare
|
@swift-ci please smoke test. |
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
lib/AST/Type.cpp
Outdated
|
|
||
| while (t) { | ||
| auto NTD = t->getAnyNominal(); | ||
| assert(NTD && "expected nominal type in NTD"); |
There was a problem hiding this comment.
Should we be tolerant of error types here, e.g., assert(NTD || t->hasError())?
There was a problem hiding this comment.
I changed the loop to while (t && !t->hasError()).
If there was any requirements in the @objc protocol, the user got an error in some form (a complaint about those requirements), but giving the direct error is better, and handles @objc protocol with no requirements. Also, fix a hole in that existing @objc method check: in `class Outer<T> { class Inner {} }`, Inner should be considered generic, but the loop that was checking for this didn't consider it. Fixes https://bugs.swift.org/browse/SR-7370 and rdar://problem/39239512.
huonw
force-pushed
the
generic-class-objc-protocol-extension
branch
from
5da5eb0
to
d33a5c1
Compare
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
If there was any requirements in the @objc protocol, the user got an error in
some form (a complaint about those requirements), but giving the direct error is
better, and handles @objc protocol with no requirements.
Fixes https://bugs.swift.org/browse/SR-7370 and rdar://problem/39239512.