New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a pair of crashes with '@unknown' #15889
Conversation
Also improve the error message when using it with a very large space. https://bugs.swift.org/browse/SR-7408
@swift-ci Please smoke test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diagnostics look great. Thank you!
If |
Yeah, I forgot about |
If someone uses it twice, or on a non-final case, or tries to use it with a multiple-pattern case, don't bother checking the exhaustiveness of the switch. (For other violations, the pattern or where-clause is ignored.) https://bugs.swift.org/browse/SR-7409
217dbc4
to
8157e80
Compare
@swift-ci Please test source compatibility |
Snuck in another PrettyStackTrace too. |
Build failed |
Build failed |
@swift-ci Please test source compatibility |
Fixes a pair of issues @rintaro caught around misuse of
@unknown default
. Let's not crash on bad user input!SR-7408, SR-7409