Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverage: fix handling of constructors and top-level decls (SR-7446) #15966

Merged
merged 3 commits into from
Apr 17, 2018
Merged

Coverage: fix handling of constructors and top-level decls (SR-7446) #15966

merged 3 commits into from
Apr 17, 2018

Commits on Apr 17, 2018

  1. [Coverage] Instrument constructor initializers (SR-7446) 

    We need to instrument constructor initializers, instead of the
delegating constructors which just call them.

rdar://39460313
    @vedantk
    vedantk committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    94da175 View commit details
    Browse the repository at this point in the history

  2. [Coverage] Remove dead code, NFC

    @vedantk
    vedantk committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    5630bd7 View commit details
    Browse the repository at this point in the history

  3. [Coverage] Use a shared profiler for constructors and member initiali… 

    …zers

This fixes coverage reporting for member initializers and cuts down on
repeated AST traversals of pattern bindings within nominal type decls.

This allows us to remove some defensive heuristic code which dealt with
closures and if-exprs within member initializers.
    @vedantk
    vedantk committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    9fa0c85 View commit details
    Browse the repository at this point in the history