[4.2] Allow synthesis of conformances in same-file extensions. #16439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of passing around a TypeChecker and three Decls (the nominal type, the protocol, and the decl declaring the conformance) everywhere, we can just pass one object. This should be [NFC].
This works for all protocols except for Decodable on non-final classes, because the init requirement has to be 'required' and thus in the type's declaration. Fixes most of https://bugs.swift.org/browse/SR-6803.
…c types. Fixes https://bugs.swift.org/browse/SR-6803 and rdar://problem/39199726.
'private' properties can't be accessed in extensions in Swift 3, so synthesizing a conformance that reads from such things is going to be incorrect in an extension.
…n conformance synthesis.
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#16376 and #16436. Fixes rdar://problem/39199726 and https://bugs.swift.org/browse/SR-6803.