Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test for SR-8209, which seems to be fixed #17838

Merged
merged 1 commit into from Jul 10, 2018
Merged

Add a test for SR-8209, which seems to be fixed #17838

merged 1 commit into from Jul 10, 2018

Conversation

jrose-apple
Copy link
Contributor

@jrose-apple
Copy link
Contributor Author

@swift-ci Please test

@jrose-apple
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Collaborator

swift-ci commented Jul 9, 2018

Build failed
Swift Test OS X Platform
Git Sha - 6a5e64597938ba3c115df0b7e81cc1338e9683b6

@swift-ci
Copy link
Collaborator

swift-ci commented Jul 9, 2018

Build failed
Swift Test Linux Platform
Git Sha - 6a5e64597938ba3c115df0b7e81cc1338e9683b6

@jrose-apple
Copy link
Contributor Author

Hm. Maybe it got broken again?

@jrose-apple
Copy link
Contributor Author

Ah, no, we're just smart enough on master to not use ObjC dispatch when the class is final. Hm. That makes it hard to recreate the original test conditions, where we failed to check that the method was @objc and therefore didn't generate the right selector for it until late. I guess I'll have to approximate.

@jrose-apple
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Collaborator

swift-ci commented Jul 9, 2018

Build failed
Swift Test Linux Platform
Git Sha - a7600e86be2aad52bcad12163d5108ed8ef2c88e

@swift-ci
Copy link
Collaborator

swift-ci commented Jul 9, 2018

Build failed
Swift Test OS X Platform
Git Sha - a7600e86be2aad52bcad12163d5108ed8ef2c88e

@jrose-apple
Copy link
Contributor Author

Unrelated LLDB failure on Linux…

@swift-ci Please test Linux

@swift-ci
Copy link
Collaborator

Build failed
Swift Test Linux Platform
Git Sha - 49462b8

@jrose-apple
Copy link
Contributor Author

@swift-ci Please test Linux

@jrose-apple jrose-apple merged commit 93fb20f into apple:master Jul 10, 2018
@jrose-apple jrose-apple deleted the test-SR8209 branch July 10, 2018 21:10
@belkadan belkadan mentioned this pull request Jul 9, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jrose-apple @swift-ci