Fix Makefile builds

[meadori]

This commit fixes two problems exposed by Makefile builds
(-m): (1) the cmark library directory is wrong and (2) the
COMMON_CMAKE_OPTIONS are not quoted when building swift (thus
"Unix Makefiles" ends up as two command line arguments).

Tested by building for Ninja (default), Make (-m), and XCode (-x).

[jrose-apple]

The Makefile build isn't really a recommended way to build Swift at this point, but that's no reason to get this wrong. Thanks!

[jrose-apple]

Also, thanks for stating which configurations you tested, and for actually testing all three of them. :-)

[meadori]

I figured the Makefile build wasn't used much, but I reasoned either it should be fixed or removed. The fix was simple. Maybe it can be deprecated later on down the road.

Thank you for merging!

[thawkins]

Makefile build produces far better progress and output information over ninja at the moment, i use it becuase of that. It also seems to impact the machine less, ninja builds seem to consume far far more memory, my 8g machine with 2 threads set, swaps under ninja but not under cmake/makefile.

[jckarter]

@thawkins ninja -v gives more make-like detailed output. You might try that.

[thawkins]

Off topic, but where do we register issues? Bugs.swift.org requires a login, but has no registration system.

[jckarter]

Click "sign up" under the login box.

[thawkins]

Ahhh, sused it, the version that is being shown to things it thinks are
mobile is not showing that link, its only visable on desktop machines, i
normaly do all my web browsing on a 12 inch android tablet, so i was not
seeing the link.

On Sat, Dec 5, 2015, 13:49 Joe Groff notifications@github.com wrote:

Click "sign up" under the login box.

—
Reply to this email directly or view it on GitHub
#184 (comment).

[gparker42]

Please file a bug report about the, er, bug reporter.

[liangdzou]

There is a bug report (SR-65) for the second problem.