Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Foundation] handle ambiguity in swift 4 mode for Data.init with byte sequences #18443

Merged
merged 2 commits into from
Aug 2, 2018
Merged

[Foundation] handle ambiguity in swift 4 mode for Data.init with byte sequences #18443

merged 2 commits into from
Aug 2, 2018

Conversation

phausler
Copy link
Contributor

@phausler phausler commented Aug 1, 2018

Inadvertently we broke projects using the functional passing for map and Data.init in swift 4 mode. Imperative initialization however was not affected. To resolve this we need to annotate that the specialization of the bytes sequence initializer needs to be introduced in swift 4.2 which should leave 4.0 mode still source compatible.

@phausler
Copy link
Contributor Author

phausler commented Aug 1, 2018

@swift-ci please smoke test

@phausler
Copy link
Contributor Author

phausler commented Aug 1, 2018

@swift-ci please smoke benchmark

@slavapestov
Copy link
Contributor

Can you add a test?

@phausler
Copy link
Contributor Author

phausler commented Aug 1, 2018

the only part that isn't tested is the swift4 mode map(Data.init) case. is there a way I can get a test compiled as swift4 mode instead of 4.2 mode?

@swift-ci
Copy link
Contributor

swift-ci commented Aug 1, 2018

Build comment file:

Optimized (O)

Regression (6)
TEST OLD NEW DELTA SPEEDUP
DictionaryBridgeToObjC_Access 1020 1126 +10.4% 0.91x (?)
ArrayAppendAscii 3885 4193 +7.9% 0.93x (?)
DataAppendBytes 5233 5607 +7.1% 0.93x
ObjectiveCBridgeStubNSDataAppend 2521 2676 +6.1% 0.94x
DataReset 2784 2942 +5.7% 0.95x (?)
COWTree 3630 3836 +5.7% 0.95x
Improvement (6)
TEST OLD NEW DELTA SPEEDUP
StringBuilderWithLongSubstring 1824 1536 -15.8% 1.19x (?)
DataReplaceSmallBuffer 10232 9013 -11.9% 1.14x
CharIndexing_russian_unicodeScalars_Backwards 14749 13391 -9.2% 1.10x
UTF8Decode_InitFromData_ascii 910 832 -8.6% 1.09x (?)
ObjectiveCBridgeFromNSDictionaryAnyObject 113065 105774 -6.4% 1.07x (?)
ObjectiveCBridgeFromNSSetAnyObjectForced 5463 5160 -5.5% 1.06x (?)
No Changes (433)
TEST OLD NEW DELTA SPEEDUP
AngryPhonebook 3598 3749 +4.2% 0.96x (?)
AnyHashableWithAClass 90943 90926 -0.0% 1.00x (?)
Array2D 2718 2718 +0.0% 1.00x
ArrayAppend 1079 1079 +0.0% 1.00x
ArrayAppendArrayOfInt 802 801 -0.1% 1.00x (?)
ArrayAppendAsciiSubstring 25293 25284 -0.0% 1.00x (?)
ArrayAppendFromGeneric 803 801 -0.2% 1.00x (?)
ArrayAppendGenericStructs 1433 1415 -1.3% 1.01x (?)
ArrayAppendLatin1 41216 41175 -0.1% 1.00x (?)
ArrayAppendLatin1Substring 139794 139677 -0.1% 1.00x (?)
ArrayAppendLazyMap 1345 1343 -0.1% 1.00x (?)
ArrayAppendOptionals 1434 1430 -0.3% 1.00x (?)
ArrayAppendRepeatCol 1343 1337 -0.4% 1.00x
ArrayAppendReserved 806 806 +0.0% 1.00x
ArrayAppendSequence 1124 1126 +0.2% 1.00x (?)
ArrayAppendStrings 6218 6223 +0.1% 1.00x (?)
ArrayAppendToFromGeneric 791 801 +1.3% 0.99x (?)
ArrayAppendToGeneric 801 799 -0.2% 1.00x (?)
ArrayAppendUTF16 41126 41195 +0.2% 1.00x (?)
ArrayAppendUTF16Substring 137420 137498 +0.1% 1.00x (?)
ArrayInClass 86 86 +0.0% 1.00x
ArrayLiteral 0 0 +0.0% 1.00x
ArrayOfGenericPOD2 152 152 +0.0% 1.00x
ArrayOfGenericRef 4368 4332 -0.8% 1.01x
ArrayOfPOD 185 186 +0.5% 0.99x (?)
ArrayOfRef 4311 4311 +0.0% 1.00x
ArrayPlusEqualArrayOfInt 801 800 -0.1% 1.00x (?)
ArrayPlusEqualFiveElementCollection 5505 5506 +0.0% 1.00x (?)
ArrayPlusEqualSingleElementCollection 1087 1079 -0.7% 1.01x
ArrayPlusEqualThreeElements 1662 1662 +0.0% 1.00x
ArraySubscript 1567 1553 -0.9% 1.01x (?)
ArrayValueProp 8 8 +0.0% 1.00x
ArrayValueProp2 8 8 +0.0% 1.00x
ArrayValueProp3 8 8 +0.0% 1.00x
ArrayValueProp4 8 8 +0.0% 1.00x
BinaryFloatingPointPropertiesBinade 31 31 +0.0% 1.00x
BinaryFloatingPointPropertiesNextUp 28 28 +0.0% 1.00x
BinaryFloatingPointPropertiesUlp 35 35 +0.0% 1.00x
BitCount 211 211 +0.0% 1.00x
ByteSwap 107 107 +0.0% 1.00x
COWArrayGuaranteedParameterOverhead 10438 10273 -1.6% 1.02x (?)
CSVParsing2 1627 1632 +0.3% 1.00x (?)
CSVParsingAlt2 1782 1779 -0.2% 1.00x (?)
CSVParsingAltIndices2 769 775 +0.8% 0.99x (?)
CStringLongAscii 3954 3955 +0.0% 1.00x (?)
CStringLongNonAscii 2377 2372 -0.2% 1.00x (?)
CStringShortAscii 3300 3311 +0.3% 1.00x (?)
Calculator 208 208 +0.0% 1.00x
CaptureProp 4088 4094 +0.1% 1.00x (?)
ChainedFilterMap 1248 1247 -0.1% 1.00x (?)
CharIndexing_ascii_unicodeScalars 17478 17450 -0.2% 1.00x (?)
CharIndexing_ascii_unicodeScalars_Backwards 17219 16544 -3.9% 1.04x (?)
CharIndexing_chinese_unicodeScalars 13232 13242 +0.1% 1.00x (?)
CharIndexing_chinese_unicodeScalars_Backwards 12129 12131 +0.0% 1.00x (?)
CharIndexing_japanese_unicodeScalars 20909 20897 -0.1% 1.00x (?)
CharIndexing_japanese_unicodeScalars_Backwards 19808 20339 +2.7% 0.97x (?)
CharIndexing_korean_unicodeScalars 16935 16947 +0.1% 1.00x (?)
CharIndexing_korean_unicodeScalars_Backwards 15726 15563 -1.0% 1.01x (?)
CharIndexing_punctuatedJapanese_unicodeScalars 3174 3176 +0.1% 1.00x (?)
CharIndexing_punctuatedJapanese_unicodeScalars_Backwards 2919 2922 +0.1% 1.00x (?)
CharIndexing_punctuated_unicodeScalars 3967 3966 -0.0% 1.00x (?)
CharIndexing_punctuated_unicodeScalars_Backwards 3656 3659 +0.1% 1.00x (?)
CharIndexing_russian_unicodeScalars 14543 14531 -0.1% 1.00x (?)
CharIndexing_tweet_unicodeScalars 34051 34092 +0.1% 1.00x (?)
CharIndexing_tweet_unicodeScalars_Backwards 32890 32299 -1.8% 1.02x (?)
CharIndexing_utf16_unicodeScalars 23070 23059 -0.0% 1.00x (?)
CharIndexing_utf16_unicodeScalars_Backwards 23237 24204 +4.2% 0.96x (?)
CharIteration_ascii_unicodeScalars 21644 21627 -0.1% 1.00x (?)
CharIteration_ascii_unicodeScalars_Backwards 14813 14798 -0.1% 1.00x (?)
CharIteration_chinese_unicodeScalars 16379 16367 -0.1% 1.00x
CharIteration_chinese_unicodeScalars_Backwards 11223 11239 +0.1% 1.00x (?)
CharIteration_japanese_unicodeScalars 25929 25914 -0.1% 1.00x
CharIteration_japanese_unicodeScalars_Backwards 17716 17705 -0.1% 1.00x (?)
CharIteration_korean_unicodeScalars 20970 20984 +0.1% 1.00x
CharIteration_korean_unicodeScalars_Backwards 14372 14357 -0.1% 1.00x (?)
CharIteration_punctuatedJapanese_unicodeScalars 3856 3858 +0.1% 1.00x (?)
CharIteration_punctuatedJapanese_unicodeScalars_Backwards 2737 2734 -0.1% 1.00x (?)
CharIteration_punctuated_unicodeScalars 4845 4846 +0.0% 1.00x (?)
CharIteration_punctuated_unicodeScalars_Backwards 3409 3417 +0.2% 1.00x (?)
CharIteration_russian_unicodeScalars 18017 18017 +0.0% 1.00x
CharIteration_russian_unicodeScalars_Backwards 12332 12362 +0.2% 1.00x
CharIteration_tweet_unicodeScalars 42786 42851 +0.2% 1.00x (?)
CharIteration_tweet_unicodeScalars_Backwards 29146 29164 +0.1% 1.00x (?)
CharIteration_utf16_unicodeScalars 28043 28015 -0.1% 1.00x (?)
CharIteration_utf16_unicodeScalars_Backwards 17719 17723 +0.0% 1.00x (?)
CharacterLiteralsLarge 5855 5856 +0.0% 1.00x (?)
CharacterLiteralsSmall 217 217 +0.0% 1.00x
CharacterPropertiesFetch 4603 4579 -0.5% 1.01x (?)
CharacterPropertiesPrecomputed 997 994 -0.3% 1.00x (?)
CharacterPropertiesStashed 1790 1782 -0.4% 1.00x (?)
CharacterPropertiesStashedMemo 1562 1562 +0.0% 1.00x
Chars2 2526 2527 +0.0% 1.00x (?)
ClassArrayGetter2 124 125 +0.8% 0.99x (?)
Combos 500 500 +0.0% 1.00x
DataAccessBytes 1148 1143 -0.4% 1.00x
DataAppendArray 5824 5634 -3.3% 1.03x (?)
DataAppendDataLargeToLarge 68894 69569 +1.0% 0.99x (?)
DataAppendDataLargeToMedium 35942 35933 -0.0% 1.00x (?)
DataAppendDataLargeToSmall 34774 34815 +0.1% 1.00x (?)
DataAppendDataMediumToLarge 37910 37963 +0.1% 1.00x (?)
DataAppendDataMediumToMedium 6626 6726 +1.5% 0.99x (?)
DataAppendDataMediumToSmall 6002 6041 +0.6% 0.99x (?)
DataAppendDataSmallToLarge 37853 37744 -0.3% 1.00x (?)
DataAppendDataSmallToMedium 6346 6516 +2.7% 0.97x (?)
DataAppendDataSmallToSmall 5939 6028 +1.5% 0.99x (?)
DataAppendSequence 21684 21778 +0.4% 1.00x (?)
DataCopyBytes 529 529 +0.0% 1.00x
DataCount 34 34 +0.0% 1.00x
DataMutateBytes 3953 3938 -0.4% 1.00x (?)
DataReplaceLarge 36677 37010 +0.9% 0.99x (?)
DataReplaceLargeBuffer 59686 58997 -1.2% 1.01x
DataReplaceMedium 8103 8103 +0.0% 1.00x
DataReplaceMediumBuffer 11555 11741 +1.6% 0.98x (?)
DataReplaceSmall 5869 5718 -2.6% 1.03x (?)
DataSetCount 572 549 -4.0% 1.04x (?)
DataSubscript 220 220 +0.0% 1.00x
DictOfArraysToArrayOfDicts 807 816 +1.1% 0.99x (?)
Dictionary 522 521 -0.2% 1.00x (?)
Dictionary2 647 648 +0.2% 1.00x (?)
Dictionary2OfObjects 2095 2096 +0.0% 1.00x (?)
Dictionary3 225 225 +0.0% 1.00x
Dictionary3OfObjects 745 744 -0.1% 1.00x (?)
Dictionary4 320 319 -0.3% 1.00x
Dictionary4Legacy 703 716 +1.8% 0.98x (?)
Dictionary4OfObjects 439 438 -0.2% 1.00x (?)
Dictionary4OfObjectsLegacy 908 907 -0.1% 1.00x (?)
DictionaryBridge 1278 1333 +4.3% 0.96x
DictionaryBridgeToObjC_Bridge 19 19 +0.0% 1.00x
DictionaryBridgeToObjC_BulkAccess 165 164 -0.6% 1.01x
DictionaryCompactMapValuesOfCastValue 14581 14595 +0.1% 1.00x (?)
DictionaryCompactMapValuesOfNilValue 7458 7269 -2.5% 1.03x
DictionaryCopy 108377 108651 +0.3% 1.00x (?)
DictionaryFilter 108291 108392 +0.1% 1.00x (?)
DictionaryGroup 216 216 +0.0% 1.00x
DictionaryGroupOfObjects 2108 2105 -0.1% 1.00x (?)
DictionaryKeysContainsCocoa 40 41 +2.5% 0.98x (?)
DictionaryKeysContainsNative 30 31 +3.3% 0.97x (?)
DictionaryLiteral 1907 1905 -0.1% 1.00x (?)
DictionaryOfObjects 2386 2395 +0.4% 1.00x (?)
DictionaryRemove 4341 4324 -0.4% 1.00x (?)
DictionaryRemoveOfObjects 25843 25768 -0.3% 1.00x (?)
DictionarySubscriptDefaultMutation 266 266 +0.0% 1.00x
DictionarySubscriptDefaultMutationArray 616 616 +0.0% 1.00x
DictionarySubscriptDefaultMutationArrayOfObjects 4048 4050 +0.0% 1.00x (?)
DictionarySubscriptDefaultMutationOfObjects 1694 1692 -0.1% 1.00x (?)
DictionarySwap 1022 1021 -0.1% 1.00x
DictionarySwapAt 8078 7828 -3.1% 1.03x (?)
DictionarySwapAtOfObjects 51980 52244 +0.5% 0.99x (?)
DictionarySwapOfObjects 8723 8774 +0.6% 0.99x
DoubleWidthDivision 0 0 +0.0% 1.00x
DropFirstAnyCollection 76 76 +0.0% 1.00x
DropFirstAnyCollectionLazy 65340 65372 +0.0% 1.00x (?)
DropFirstAnySeqCRangeIter 93 93 +0.0% 1.00x
DropFirstAnySeqCRangeIterLazy 93 93 +0.0% 1.00x
DropFirstAnySeqCntRange 71 71 +0.0% 1.00x
DropFirstAnySeqCntRangeLazy 71 71 +0.0% 1.00x
DropFirstAnySequence 1843 1842 -0.1% 1.00x (?)
DropFirstAnySequenceLazy 1842 1843 +0.1% 1.00x
DropFirstArray 35 35 +0.0% 1.00x
DropFirstArrayLazy 35 35 +0.0% 1.00x
DropFirstCountableRange 35 35 +0.0% 1.00x
DropFirstCountableRangeLazy 35 35 +0.0% 1.00x
DropFirstSequence 2680 2682 +0.1% 1.00x
DropFirstSequenceLazy 2767 2768 +0.0% 1.00x (?)
DropLastAnyCollection 28 28 +0.0% 1.00x
DropLastAnyCollectionLazy 21846 21782 -0.3% 1.00x (?)
DropLastAnySeqCRangeIter 3377 3380 +0.1% 1.00x (?)
DropLastAnySeqCRangeIterLazy 3387 3382 -0.1% 1.00x (?)
DropLastAnySeqCntRange 11 11 +0.0% 1.00x
DropLastAnySeqCntRangeLazy 11 11 +0.0% 1.00x
DropLastAnySequence 4960 4953 -0.1% 1.00x (?)
DropLastAnySequenceLazy 5063 5053 -0.2% 1.00x (?)
DropLastSequence 639 640 +0.2% 1.00x (?)
DropLastSequenceLazy 639 639 +0.0% 1.00x
DropWhileAnyCollection 100 100 +0.0% 1.00x
DropWhileAnyCollectionLazy 130 130 +0.0% 1.00x
DropWhileAnySeqCRangeIter 76 76 +0.0% 1.00x
DropWhileAnySeqCRangeIterLazy 130 130 +0.0% 1.00x
DropWhileAnySeqCntRange 95 95 +0.0% 1.00x
DropWhileAnySeqCntRangeLazy 130 130 +0.0% 1.00x
DropWhileAnySequence 1860 1861 +0.1% 1.00x (?)
DropWhileAnySequenceLazy 1855 1856 +0.1% 1.00x (?)
DropWhileArrayLazy 88 88 +0.0% 1.00x
DropWhileCountableRange 36 35 -2.8% 1.03x
DropWhileCountableRangeLazy 105 105 +0.0% 1.00x
DropWhileSequence 2204 2203 -0.0% 1.00x (?)
DropWhileSequenceLazy 88 88 +0.0% 1.00x
EqualStringSubstring 49 49 +0.0% 1.00x
EqualSubstringString 48 48 +0.0% 1.00x
EqualSubstringSubstring 48 48 +0.0% 1.00x
EqualSubstringSubstringGenericEquatable 48 48 +0.0% 1.00x
ErrorHandling 1218 1219 +0.1% 1.00x (?)
ExclusivityGlobal 5 5 +0.0% 1.00x
ExclusivityIndependent 2 2 +0.0% 1.00x
FatCompactMap 1247 1247 +0.0% 1.00x
FilterEvenUsingReduce 1350 1357 +0.5% 0.99x (?)
FilterEvenUsingReduceInto 163 163 +0.0% 1.00x
FloatingPointPrinting_Double_description_small 21769 21761 -0.0% 1.00x (?)
FloatingPointPrinting_Double_description_uniform 21147 21140 -0.0% 1.00x (?)
FloatingPointPrinting_Double_interpolated 61061 61610 +0.9% 0.99x (?)
FloatingPointPrinting_Float80_description_small 28418 28353 -0.2% 1.00x (?)
FloatingPointPrinting_Float80_description_uniform 27444 27366 -0.3% 1.00x (?)
FloatingPointPrinting_Float80_interpolated 64741 64971 +0.4% 1.00x (?)
FloatingPointPrinting_Float_description_small 5559 5548 -0.2% 1.00x (?)
FloatingPointPrinting_Float_description_uniform 5295 5295 +0.0% 1.00x
FloatingPointPrinting_Float_interpolated 38066 38181 +0.3% 1.00x (?)
FrequenciesUsingReduce 5235 5421 +3.6% 0.97x (?)
FrequenciesUsingReduceInto 1571 1568 -0.2% 1.00x (?)
Hanoi 2182 2189 +0.3% 1.00x (?)
HashTest 988 970 -1.8% 1.02x
Histogram 673 672 -0.1% 1.00x
Integrate 335 335 +0.0% 1.00x
IterateData 1727 1728 +0.1% 1.00x (?)
Join 161 161 +0.0% 1.00x
LazilyFilteredArrayContains 35471 35463 -0.0% 1.00x (?)
LazilyFilteredArrays2 4630 4635 +0.1% 1.00x (?)
LazilyFilteredRange 3746 3738 -0.2% 1.00x
LessSubstringSubstring 48 48 +0.0% 1.00x
LessSubstringSubstringGenericComparable 49 48 -2.0% 1.02x
LinkedList 7567 7557 -0.1% 1.00x
LuhnAlgoEager 451 450 -0.2% 1.00x (?)
LuhnAlgoLazy 448 453 +1.1% 0.99x (?)
MapReduce 401 399 -0.5% 1.01x (?)
MapReduceAnyCollection 399 403 +1.0% 0.99x (?)
MapReduceAnyCollectionShort 2077 2071 -0.3% 1.00x (?)
MapReduceClass 3003 3006 +0.1% 1.00x (?)
MapReduceClassShort 4573 4567 -0.1% 1.00x (?)
MapReduceLazyCollection 13 13 +0.0% 1.00x
MapReduceLazyCollectionShort 34 34 +0.0% 1.00x
MapReduceLazySequence 86 86 +0.0% 1.00x
MapReduceSequence 463 464 +0.2% 1.00x (?)
MapReduceShort 2016 2010 -0.3% 1.00x (?)
MapReduceShortString 20 20 +0.0% 1.00x
MapReduceString 48 48 +0.0% 1.00x
Memset 221 214 -3.2% 1.03x
MonteCarloE 10254 10258 +0.0% 1.00x (?)
MonteCarloPi 42677 42679 +0.0% 1.00x (?)
NSDictionaryCastToSwift 7118 7297 +2.5% 0.98x (?)
NSError 165 166 +0.6% 0.99x (?)
NSStringConversion 691 703 +1.7% 0.98x
NibbleSort 3460 3462 +0.1% 1.00x (?)
NopDeinit 32336 32330 -0.0% 1.00x (?)
ObjectAllocation 132 132 +0.0% 1.00x
ObjectiveCBridgeFromNSArrayAnyObject 25965 27212 +4.8% 0.95x (?)
ObjectiveCBridgeFromNSArrayAnyObjectForced 4656 4683 +0.6% 0.99x (?)
ObjectiveCBridgeFromNSArrayAnyObjectToString 47034 47669 +1.4% 0.99x (?)
ObjectiveCBridgeFromNSArrayAnyObjectToStringForced 46647 45479 -2.5% 1.03x (?)
ObjectiveCBridgeFromNSSetAnyObject 48484 48824 +0.7% 0.99x (?)
ObjectiveCBridgeFromNSSetAnyObjectToString 72553 73535 +1.4% 0.99x (?)
ObjectiveCBridgeFromNSString 1237 1240 +0.2% 1.00x (?)
ObjectiveCBridgeFromNSStringForced 2726 2740 +0.5% 0.99x (?)
ObjectiveCBridgeStubDataAppend 6498 6394 -1.6% 1.02x (?)
ObjectiveCBridgeStubDateMutation 401 400 -0.2% 1.00x (?)
ObjectiveCBridgeStubFromArrayOfNSString2 3419 3418 -0.0% 1.00x (?)
ObjectiveCBridgeStubFromNSString 1044 1040 -0.4% 1.00x (?)
ObjectiveCBridgeStubToArrayOfNSString2 4075 4085 +0.2% 1.00x (?)
ObjectiveCBridgeStubToNSDate2 1616 1616 +0.0% 1.00x
ObjectiveCBridgeStubToNSString 2350 2349 -0.0% 1.00x (?)
ObjectiveCBridgeStubToNSStringRef 124 124 +0.0% 1.00x
ObjectiveCBridgeStubURLAppendPath2 2850 2797 -1.9% 1.02x (?)
ObjectiveCBridgeStubURLAppendPathRef2 2773 2831 +2.1% 0.98x (?)
ObjectiveCBridgeToNSArray 15415 15071 -2.2% 1.02x (?)
ObjectiveCBridgeToNSDictionary 28401 29146 +2.6% 0.97x (?)
ObjectiveCBridgeToNSSet 18365 17533 -4.5% 1.05x (?)
ObjectiveCBridgeToNSString 450 453 +0.7% 0.99x
ObserverClosure 2178 2174 -0.2% 1.00x (?)
ObserverForwarderStruct 1207 1198 -0.7% 1.01x (?)
ObserverPartiallyAppliedMethod 3785 3789 +0.1% 1.00x (?)
ObserverUnappliedMethod 2458 2471 +0.5% 0.99x (?)
OpaqueConsumingUsers 4178 4179 +0.0% 1.00x (?)
OpenClose 65 65 +0.0% 1.00x
Phonebook 7333 7325 -0.1% 1.00x (?)
PointerArithmetics 31501 31495 -0.0% 1.00x (?)
PolymorphicCalls 25 25 +0.0% 1.00x
PopFrontArray 1824 1828 +0.2% 1.00x (?)
PopFrontArrayGeneric 1842 1829 -0.7% 1.01x (?)
PopFrontUnsafePointer 8790 8704 -1.0% 1.01x (?)
PrefixAnyCollection 76 76 +0.0% 1.00x
PrefixAnyCollectionLazy 65414 65302 -0.2% 1.00x (?)
PrefixAnySeqCRangeIter 40 40 +0.0% 1.00x
PrefixAnySeqCRangeIterLazy 40 40 +0.0% 1.00x
PrefixAnySeqCntRange 71 71 +0.0% 1.00x
PrefixAnySeqCntRangeLazy 71 71 +0.0% 1.00x
PrefixAnySequence 1379 1379 +0.0% 1.00x
PrefixAnySequenceLazy 1379 1377 -0.1% 1.00x (?)
PrefixArray 35 35 +0.0% 1.00x
PrefixArrayLazy 35 35 +0.0% 1.00x
PrefixCountableRange 35 35 +0.0% 1.00x
PrefixCountableRangeLazy 35 35 +0.0% 1.00x
PrefixSequence 2211 2213 +0.1% 1.00x (?)
PrefixSequenceLazy 2275 2276 +0.0% 1.00x
PrefixWhileAnyCollection 147 147 +0.0% 1.00x
PrefixWhileAnyCollectionLazy 71 71 +0.0% 1.00x
PrefixWhileAnySeqCRangeIter 386 386 +0.0% 1.00x
PrefixWhileAnySeqCRangeIterLazy 89 89 +0.0% 1.00x
PrefixWhileAnySequence 1541 1541 +0.0% 1.00x
PrefixWhileAnySequenceLazy 1391 1391 +0.0% 1.00x
PrefixWhileArray 88 88 +0.0% 1.00x
PrefixWhileArrayLazy 70 70 +0.0% 1.00x
PrefixWhileSequence 362 364 +0.6% 0.99x
PrefixWhileSequenceLazy 52 52 +0.0% 1.00x
Prims 929 933 +0.4% 1.00x (?)
PrimsSplit 934 934 +0.0% 1.00x
QueueConcrete 1154 1155 +0.1% 1.00x
QueueGeneric 1137 1139 +0.2% 1.00x (?)
RC4 149 151 +1.3% 0.99x
RGBHistogram 2628 2627 -0.0% 1.00x (?)
RGBHistogramOfObjects 20284 20439 +0.8% 0.99x
Radix2CooleyTukey 12544 12469 -0.6% 1.01x (?)
Radix2CooleyTukeyf 8981 9284 +3.4% 0.97x
RandomDoubleDef 27027 27028 +0.0% 1.00x (?)
RandomDoubleLCG 2233 2232 -0.0% 1.00x (?)
RandomIntegersDef 24403 24416 +0.1% 1.00x (?)
RandomIntegersLCG 173 173 +0.0% 1.00x
RandomShuffleDef2 2589 2579 -0.4% 1.00x (?)
RandomShuffleLCG2 1806 1806 +0.0% 1.00x
RangeAssignment 337 340 +0.9% 0.99x (?)
RangeIterationSigned 200 200 +0.0% 1.00x
RangeReplaceableCollectionPlusDefault 1071 1077 +0.6% 0.99x
RecursiveOwnedParameter 115 115 +0.0% 1.00x
RemoveWhereFilterInts 47 47 +0.0% 1.00x
RemoveWhereFilterString 239 240 +0.4% 1.00x (?)
RemoveWhereFilterStrings 438 438 +0.0% 1.00x
RemoveWhereMoveInts 14 14 +0.0% 1.00x
RemoveWhereMoveStrings 709 710 +0.1% 1.00x
RemoveWhereQuadraticInts 1295 1296 +0.1% 1.00x (?)
RemoveWhereQuadraticString 385 372 -3.4% 1.03x
RemoveWhereQuadraticStrings 2759 2759 +0.0% 1.00x
RemoveWhereSwapInts 19 20 +5.3% 0.95x
RemoveWhereSwapStrings 859 860 +0.1% 1.00x
ReversedArray2 200 200 +0.0% 1.00x
ReversedBidirectional 14207 14227 +0.1% 1.00x (?)
ReversedDictionary2 316 316 +0.0% 1.00x
RomanNumbers 81196 81251 +0.1% 1.00x (?)
SequenceAlgosAnySequence 12518 12505 -0.1% 1.00x (?)
SequenceAlgosArray 1575 1578 +0.2% 1.00x (?)
SequenceAlgosContiguousArray 1582 1567 -0.9% 1.01x (?)
SequenceAlgosList 1353 1354 +0.1% 1.00x (?)
SequenceAlgosRange 2576 2579 +0.1% 1.00x (?)
SequenceAlgosUnfoldSequence 1102 1102 +0.0% 1.00x
SetExclusiveOr 5046 5056 +0.2% 1.00x (?)
SetExclusiveOr_OfObjects 11899 11888 -0.1% 1.00x (?)
SetIntersect 697 699 +0.3% 1.00x (?)
SetIntersect_OfObjects 1712 1720 +0.5% 1.00x (?)
SetIsSubsetOf 329 329 +0.0% 1.00x
SetIsSubsetOf_OfObjects 441 441 +0.0% 1.00x
SetUnion 4355 4392 +0.8% 0.99x
SetUnion_OfObjects 10229 10178 -0.5% 1.01x (?)
SevenBoom 843 853 +1.2% 0.99x
Sim2DArray 417 417 +0.0% 1.00x
SortLargeExistentials 5518 5530 +0.2% 1.00x (?)
SortLettersInPlace 972 974 +0.2% 1.00x
SortSortedStrings 708 706 -0.3% 1.00x
SortStrings 1505 1503 -0.1% 1.00x
SortStringsUnicode 2192 2190 -0.1% 1.00x (?)
StackPromo 24692 24764 +0.3% 1.00x (?)
StaticArray 10 10 +0.0% 1.00x
StrComplexWalk 1776 1777 +0.1% 1.00x
StrToInt 3330 3330 +0.0% 1.00x
StringAdder 552 552 +0.0% 1.00x
StringBuilder 496 496 +0.0% 1.00x
StringBuilderLong 1230 1226 -0.3% 1.00x (?)
StringBuilderSmallReservingCapacity 506 506 +0.0% 1.00x
StringComparison_abnormal 833 835 +0.2% 1.00x (?)
StringComparison_ascii 1028 1030 +0.2% 1.00x (?)
StringComparison_emoji 869 864 -0.6% 1.01x (?)
StringComparison_fastPrenormal 859 859 +0.0% 1.00x
StringComparison_latin1 676 676 +0.0% 1.00x
StringComparison_longSharedPrefix 963 964 +0.1% 1.00x
StringComparison_nonBMPSlowestPrenormal 1686 1683 -0.2% 1.00x
StringComparison_slowerPrenormal 1800 1801 +0.1% 1.00x (?)
StringComparison_zalgo 112579 112455 -0.1% 1.00x (?)
StringEdits 171866 170787 -0.6% 1.01x (?)
StringEnumRawValueInitialization 861 855 -0.7% 1.01x
StringEqualPointerComparison 286 286 +0.0% 1.00x
StringFromLongWholeSubstring 21 21 +0.0% 1.00x
StringFromLongWholeSubstringGeneric 21 21 +0.0% 1.00x
StringHasPrefixAscii 2261 2263 +0.1% 1.00x
StringHasPrefixUnicode 100939 100962 +0.0% 1.00x (?)
StringHasSuffixAscii 2290 2290 +0.0% 1.00x
StringHasSuffixUnicode 100547 100403 -0.1% 1.00x (?)
StringHashing_abnormal 1362 1364 +0.1% 1.00x (?)
StringHashing_ascii 35 35 +0.0% 1.00x
StringHashing_emoji 1944 1930 -0.7% 1.01x (?)
StringHashing_fastPrenormal 8574 8580 +0.1% 1.00x (?)
StringHashing_latin1 2647 2633 -0.5% 1.01x (?)
StringHashing_longSharedPrefix 8043 8079 +0.4% 1.00x
StringHashing_nonBMPSlowestPrenormal 2150 2093 -2.7% 1.03x (?)
StringHashing_slowerPrenormal 2809 2802 -0.2% 1.00x (?)
StringHashing_zalgo 3527 3548 +0.6% 0.99x (?)
StringInterpolation 8867 8774 -1.0% 1.01x (?)
StringInterpolationManySmallSegments 17617 17629 +0.1% 1.00x (?)
StringInterpolationSmall 4017 4018 +0.0% 1.00x (?)
StringMatch 12101 12124 +0.2% 1.00x (?)
StringRemoveDupes 494 492 -0.4% 1.00x (?)
StringUTF16Builder 2540 2577 +1.5% 0.99x (?)
StringUTF16SubstringBuilder 5654 5641 -0.2% 1.00x (?)
StringWalk 1549 1549 +0.0% 1.00x
StringWithCString2 1974 1977 +0.2% 1.00x
StringWordBuilder 2258 2261 +0.1% 1.00x (?)
StringWordBuilderReservingCapacity 1663 1652 -0.7% 1.01x
SubstringComparable 13 13 +0.0% 1.00x
SubstringEqualString 605 604 -0.2% 1.00x (?)
SubstringEquatable 1415 1419 +0.3% 1.00x
SubstringFromLongString 10 10 +0.0% 1.00x
SubstringFromLongStringGeneric 74 74 +0.0% 1.00x
SuffixAnyCollection 28 28 +0.0% 1.00x
SuffixAnyCollectionLazy 21775 21751 -0.1% 1.00x (?)
SuffixAnySeqCRangeIter 3666 3670 +0.1% 1.00x (?)
SuffixAnySeqCRangeIterLazy 3673 3666 -0.2% 1.00x
SuffixAnySeqCntRange 17 17 +0.0% 1.00x
SuffixAnySeqCntRangeLazy 17 17 +0.0% 1.00x
SuffixAnySequence 4930 4930 +0.0% 1.00x
SuffixAnySequenceLazy 5052 5058 +0.1% 1.00x (?)
SuffixSequence 3631 3641 +0.3% 1.00x (?)
SuffixSequenceLazy 3633 3638 +0.1% 1.00x
SumUsingReduce 102 101 -1.0% 1.01x
SumUsingReduceInto 97 97 +0.0% 1.00x
SuperChars 19423 19382 -0.2% 1.00x (?)
TwoSum 1486 1493 +0.5% 1.00x (?)
TypeFlood 0 0 +0.0% 1.00x
UTF8Decode 299 299 +0.0% 1.00x
UTF8Decode_InitDecoding 1352 1353 +0.1% 1.00x (?)
UTF8Decode_InitDecoding_ascii 656 657 +0.2% 1.00x (?)
UTF8Decode_InitFromBytes 1184 1186 +0.2% 1.00x (?)
UTF8Decode_InitFromBytes_ascii 531 527 -0.8% 1.01x (?)
UTF8Decode_InitFromData 1286 1273 -1.0% 1.01x
Walsh 428 430 +0.5% 1.00x (?)
WordCountHistogramASCII 7013 7011 -0.0% 1.00x (?)
WordCountHistogramUTF16 10748 10800 +0.5% 1.00x (?)
WordCountUniqueASCII 2201 2177 -1.1% 1.01x
WordCountUniqueUTF16 4885 4866 -0.4% 1.00x (?)
XorLoop 403 409 +1.5% 0.99x (?)
Hardware Overview 
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

@phausler
Copy link
Contributor Author

phausler commented Aug 1, 2018

@swift-ci please smoke test

@xedin
Copy link
Contributor

xedin commented Aug 1, 2018

AFAIK you can pass both 4 and 4.2 to -swift-version

@phausler
Copy link
Contributor Author

phausler commented Aug 1, 2018

@swift-ci please smoke test

slavapestov
slavapestov reviewed Aug 1, 2018
View reviewed changes
test/stdlib/TestData_Swift4.swift
var DataTests = TestSuite("TestDataSwift4")

DataTests.test("functional map init usage") {
let res1 = [[UInt8(0), UInt8(1), UInt8(2)]].map(Data.init) // previously this could be done without being ambiguous (however in swift 4.2 an overload was added that makes it ambiguous as a function ref)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I had in mind, thanks!

@phausler
Copy link
Contributor Author

phausler commented Aug 1, 2018

@swift-ci please smoke test

@phausler
Copy link
Contributor Author

phausler commented Aug 1, 2018

@swift-ci please smoke test

@phausler
Copy link
Contributor Author

phausler commented Aug 2, 2018

@swift-ci please smoke test

@phausler phausler requested a review from parkera August 2, 2018 15:53
@phausler
Copy link
Contributor Author

phausler commented Aug 2, 2018

@swift-ci please smoke test and merge

@parkera
Copy link
Contributor

parkera commented Aug 2, 2018

@swift-ci smoke test and merge

@swift-ci swift-ci merged commit c1029b6 into swiftlang:master Aug 2, 2018
@pixelmatrix pixelmatrix mentioned this pull request Sep 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavapestov slavapestov slavapestov left review comments

@parkera parkera parkera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@phausler @slavapestov @swift-ci @xedin @parkera