Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sema] Fix a crash in use-before-declaration case #18466

Merged
merged 1 commit into from Aug 3, 2018

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Aug 2, 2018

Check "use-before-declaration" early so we don't typecheck referenced decl which might depends on the reference.

https://bugs.swift.org/browse/SR-7517
https://bugs.swift.org/browse/SR-8447
rdar://problem/39782719

@rintaro rintaro requested a review from DougGregor August 2, 2018 09:51
@rintaro
Copy link
Member Author

rintaro commented Aug 2, 2018

@swift-ci Please smoke test

Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Check use-before-declaration early so we don't typecheck referenced decl
which might depends on the reference.

https://bugs.swift.org/browse/SR-7517
https://bugs.swift.org/browse/SR-8447
rdar://problem/39782719
@rintaro
Copy link
Member Author

rintaro commented Aug 3, 2018

@swift-ci Please smoke test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants