[WIP][Parser][SR-1052] Added @discardableResult attribute parsing. #1887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Future commits will add use in diagnostic generation, stdlib, etc.
| @@ -653,6 +654,7 @@ class AttributeChecker : public AttributeVisitor<AttributeChecker> { | |||
| IGNORED_ATTR(Testable) | |||
| IGNORED_ATTR(WarnUnqualifiedAccess) | |||
| IGNORED_ATTR(ShowInInterface) | |||
| IGNORED_ATTR(DiscardableResult) | |||
There was a problem hiding this comment.
Should the @discardableResult attribute be allowed on Void functions?
Currently @warn_unused_result is allowed in that case, but I'm not sure it makes sense for the new attribute.
tanadeau
changed the title
|
This looks great, sorry for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Part 1 for SR-1052: Add parsing of new
@discardableResultattribute.Future commits will add use in diagnostic generation, stdlib, etc.
Resolved bug number: Part 1 of SR-1052
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Note: Only members of the Apple organization can trigger swift-ci.