Refactor the preheader subst map computation in SESE canonicalization. #19324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test tensorflow linux |
|
@swift-ci please test tensorflow macos |
rxwei
approved these changes
Sep 17, 2018
| @@ -316,6 +316,13 @@ class SingleExitLoopTransformer { | |||
|
|
|||
| void initialize(); | |||
|
|
|||
| /// Return a map that captures information about what SILValue should be | |||
| /// used at the pre-header of the loop for every SILValue in the given | |||
| /// `values` set. If it cannnot find a suitable SILValue for an entry in | |||
| } | ||
| // Do not eliminate undefs unless requested for. | ||
| if (!TFNoUndefsInSESE) return result; |
There was a problem hiding this comment.
Seems to be a double-width space before return?
mhong
approved these changes
Sep 17, 2018
| @@ -403,14 +423,14 @@ void SingleExitLoopTransformer::initialize() { | |||
|
|
|||
| llvm::DenseMap<SILValue, SILValue> | |||
| SingleExitLoopTransformer::computeEscapingValues() const { | |||
There was a problem hiding this comment.
can this be a static method?
There was a problem hiding this comment.
Unfortunately no as it relies on some object state.
bgogul
commented
Sep 17, 2018
| @@ -403,14 +423,14 @@ void SingleExitLoopTransformer::initialize() { | |||
|
|
|||
| llvm::DenseMap<SILValue, SILValue> | |||
| SingleExitLoopTransformer::computeEscapingValues() const { | |||
There was a problem hiding this comment.
Unfortunately no as it relies on some object state.
| } | ||
| // Do not eliminate undefs unless requested for. | ||
| if (!TFNoUndefsInSESE) return result; |
| @@ -316,6 +316,13 @@ class SingleExitLoopTransformer { | |||
|
|
|||
| void initialize(); | |||
|
|
|||
| /// Return a map that captures information about what SILValue should be | |||
| /// used at the pre-header of the loop for every SILValue in the given | |||
| /// `values` set. If it cannnot find a suitable SILValue for an entry in | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring some code that I find useful for subsequent PRs.