IRGen: Fix type of a global with tail allocated storage #19397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cast the result to the expected type rather than a special '..._tailelemsN' type. rdar://44563038
|
@swift-ci Please test and merge |
eeckstein
reviewed
Sep 19, 2018
| @@ -1768,6 +1769,7 @@ Address IRGenModule::getAddrOfSILGlobalVariable(SILGlobalVariable *var, | |||
| storageType = Layout->getType(); | |||
| fixedSize = Layout->getSize(); | |||
| fixedAlignment = Layout->getAlignment(); | |||
| castStorageToType = cast<FixedTypeInfo>(ti).getStorageType(); | |||
There was a problem hiding this comment.
Maybe I missed something in the logic here. But why did you introduce a new variable 'castStorageToType' and not just assign 'storageType' here?
There was a problem hiding this comment.
It is used to create the global variable.
Here:
https://github.com/apple/swift/pull/19397/files#diff-62e4305d226cedd49d95b3dff4f8b7b8R1831
|
@swift-ci Please test |
|
Build failed |
|
@swift-ci Please test and merge |
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
Test failure unrelated. |
|
@swift-ci Please test mac os |
|
@swift-ci Please test macos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cast the result to the expected type rather than a special
'..._tailelemsN' type.
rdar://44563038