Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to docs referenced from Driver.md #19420

Merged
merged 1 commit into from
Sep 21, 2018

Conversation

kastiglione
Copy link
Contributor

@kastiglione kastiglione commented Sep 20, 2018

This change adds markdown links for references to other docs. Without this, the docs are bare text.

Because of wrapping, the diff is not clear. A --word-diff shows the following substitutions:

[-DriverInternals.rst-]{+[DriverInternals.rst](DriverInternals.rst)+}
[-DependencyAnalysis.rst-]{+[DependencyAnalysis.rst](DependencyAnalysis.rst)+}
[-Lexicon.rst-]{+[Lexicon.rst](Lexicon.rst)+}
[-DependencyAnalysis.rst.-]{+[DependencyAnalysis.rst](DependencyAnalysis.rst).+}

Copy link
Contributor

@jrose-apple jrose-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Dave!

@jrose-apple
Copy link
Contributor

@swift-ci Please smoke test

@jrose-apple jrose-apple self-assigned this Sep 20, 2018
@kastiglione
Copy link
Contributor Author

@jrose-apple The docs are really well written and contain a lot of great information. Thank you to all who have taken the time to write them up.

@jrose-apple jrose-apple merged commit 5f46179 into swiftlang:master Sep 21, 2018
@kastiglione kastiglione deleted the driver-doc-links branch January 2, 2020 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants