Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP [ConstraintSystem] Ability to treat key path literal syntax as function type (Root) -> Value. #19448

Closed
wants to merge 6 commits into from
Closed

WIP [ConstraintSystem] Ability to treat key path literal syntax as function type (Root) -> Value. #19448

wants to merge 6 commits into from

Commits on Sep 21, 2018

  1. Implicit conversion of KeyPath<Root,Value> to (Root) -> Value.

    @gregomni
    gregomni committed Sep 21, 2018
    Configuration menu
    Copy the full SHA
    9661078 View commit details
    Browse the repository at this point in the history

  2. Fix autoclosure param interface type when it involves archetypes.

    @gregomni
    gregomni committed Sep 21, 2018
    Configuration menu
    Copy the full SHA
    d48e44a View commit details
    Browse the repository at this point in the history

  3. Had some repeated locals from moving this block of code around - clea… 

    …ned up.
    @gregomni
    gregomni committed Sep 21, 2018
    Configuration menu
    Copy the full SHA
    87c2177 View commit details
    Browse the repository at this point in the history

  4. Alternate implementation where KeyPathExpr is essentially a literal t… 

    …ype and can be either a KeyPath(R,V) or (R)->V.
    @gregomni
    gregomni committed Sep 21, 2018
    Configuration menu
    Copy the full SHA
    f0378da View commit details
    Browse the repository at this point in the history

  5. Some unneccessary code now.

    @gregomni
    gregomni committed Sep 21, 2018
    Configuration menu
    Copy the full SHA
    c3fd19c View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2018

  1. Implicit closure pieces need valid sourceLocs in case a coerce expr n… 

    …eeds to refer to the beginning of the closure in `\.foo as (A) -> B`.

Removed explicit noescape from function type so `let a: (A) -> B = \.foo` is valid.
Remove optimization that optional path is always read-only KP type in CSGen, since it can also now be of function type.
    @gregomni
    gregomni committed Sep 27, 2018
    Configuration menu
    Copy the full SHA
    a1cb802 View commit details
    Browse the repository at this point in the history