[silgenpattern] Fix pattern emission of tuples with address only and … #19959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loadable components. The problem here was that if we had a tuple with mixed address only and loadable components and we used take on success during pattern matching, we would load the loadable component with a load [take] and then pass it as take on success. Instead we load the loadable components of the tuple using a load_borrow and make the cast consumption kind BorrowAlways. This can not happen with enum element emission since enum element emission does not support take_on_success so the problem can not occur there. SR-9029 rdar://45345844
|
@clackary I think this fixes the source compat stuff. |
|
@swift-ci smoke test |
|
@swift-ci test source compatibility |
|
I tested locally that fluent/SwiftLint are passing now. |
|
18:26:44 UPASS: https://bugs.swift.org/browse/SR-9029, fluent, 4.2, 270b6f, Swift Package |
|
It looks like the reactive cocoa/reactive swift failures aren't mine. They are occuring already here: https://ci.swift.org/view/all/job/swift-master-source-compat-suite-debug/323/console |
gottesmm
added a commit
to gottesmm/swift-source-compat-suite
that referenced
this pull request
Oct 20, 2018
This reverts commit 70ddb37. I fixed these in: apple/swift#19959
|
Got ufails also on the release build. I want to get this in... committing! |
|
erm UPasses ; ). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…loadable components.
The problem here was that if we had a tuple with mixed address only and loadable
components and we used take on success during pattern matching, we would load
the loadable component with a load [take] and then pass it as take on success.
Instead we load the loadable components of the tuple using a load_borrow and
make the cast consumption kind BorrowAlways.
This can not happen with enum element emission since enum element emission does
not support take_on_success so the problem can not occur there.
SR-9029
rdar://45345844