Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build-preset] Add no_test variants of all of the buildbot_linux_* pr… #20109

Merged

Conversation

gottesmm
Copy link
Member

…esets.

The key thing is that these skip all testing except for the integration testing
and thus are perfect for subproject buildbot testing.

The reason why I am doing this is I discovered that dispatch is not using
build-presets. This means that dispatch may not get updated properly (resulting
in integration test failures) when we add new package installation dependencies
(like llvm-cov, llvm-profdata) for the integration tests.

This is functionally the same as dispatch's build today except that we /will/
build lldb. That being said I think it makes sense to build the entire package
for dispatch so if we have any integration issues in between lldb and dispatch
we can test them.

SR-9080

@gottesmm
Copy link
Member Author

@swift-ci smoke test

@gottesmm
Copy link
Member Author

preset=buildbot_linux_1604,notest
@swift-ci Please test with preset Linux Platform

@gottesmm
Copy link
Member Author

Looks like, I can't use multiple mixins = (.

@gottesmm
Copy link
Member Author

Nope. I just messed up.

Copy link
Member

@ankitspd ankitspd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

…esets.

The key thing is that these skip all testing except for the integration testing
and thus are perfect for subproject buildbot testing.

The reason why I am doing this is I discovered that dispatch is not using
build-presets. This means that dispatch may not get updated properly (resulting
in integration test failures) when we add new package installation dependencies
(like llvm-cov, llvm-profdata) for the integration tests.

This is functionally the same as dispatch's build today except that we /will/
build lldb. That being said I think it makes sense to build the entire package
for dispatch so if we have any integration issues in between lldb and dispatch
we can test them.

SR-9080
@gottesmm gottesmm force-pushed the pr-60b76bba625dd71797c6790a927e6b56081af615 branch from 0e7e4db to d6323fb Compare October 27, 2018 22:20
@gottesmm
Copy link
Member Author

preset=buildbot_linux_1604,notest
@swift-ci Please test with preset Linux Platform

1 similar comment
@gottesmm
Copy link
Member Author

preset=buildbot_linux_1604,notest
@swift-ci Please test with preset Linux Platform

@gottesmm
Copy link
Member Author

@swift-ci smoke test

2 similar comments
@gottesmm
Copy link
Member Author

@swift-ci smoke test

@gottesmm
Copy link
Member Author

@swift-ci smoke test

@gottesmm
Copy link
Member Author

preset=buildbot_linux_1604,notest
@swift-ci Please test with preset Linux Platform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants