[unittests] Ignore googletest DWARF directories #2054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Swift build system does not generate DWARF symbols in the unittests build directory. For build systems that do, however, files would be generated with the test suffix "Tests". These need to be excluded because otherwise `lit.formats.GoogleTest` tries to execute them.
|
/cc @gribozavr |
|
@swift-ci Please test and merge |
|
Hmm, looks like the Linux test failed. Something to do with SwiftPM and package-tests (I believe this is a known issue on master at the moment). The Swift test suite, on the other hand, appears to have completed successfully. Anyone mind if I merge this before the SwiftPM failure is fixed? |
|
Go for it, that test failure is being addressed independently. |
|
Great, thanks!! 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
The Swift build system does not generate DWARF symbols in the unittests build directory. For build systems that do, however, files would be generated with the test suffix "Tests". These need to be excluded because otherwise
lit.formats.GoogleTesttries to execute them. See http://reviews.llvm.org/D18647 for details./cc @ddunbar
Resolved bug number: (SR-)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Note: Only members of the Apple organization can trigger swift-ci.