[IRGen] Add assertion to emitPHINodesForBBArgs
#207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converted the check that the DebugScope `DS` exists and that the DebugScope's `SILFn` is the same as the `IGF`'s to an assertion based on the FIXME's suggestion on line 831.
|
Thanks! Have you tested whether any code or test cases rely on the fallback behavior? |
|
@jckarter -- I ensured that no tests broke between |
|
Good to hear. @adrian-prantl, anything we should try before adding this assert? |
|
Thanks. After 8ab1e2d, this assertion should now always hold. |
|
Thanks @adrian-prantl. @mrecachinas, I'll accept this, and let you know if we see anything break. Thank you again for contributing! |
jckarter
added a commit
that referenced
this pull request
Dec 4, 2015
[IRGen] Add assertion to `emitPHINodesForBBArgs`
slavapestov
pushed a commit
to slavapestov/swift
that referenced
this pull request
Nov 27, 2018
SR-3771 and SR-3751: libdispatch should not depend on external libkqueue
slavapestov
pushed a commit
to slavapestov/swift
that referenced
this pull request
Nov 27, 2018
SR-3771 and SR-3751: libdispatch should not depend on external libkqueue Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
maldahleh
pushed a commit
to maldahleh/swift
that referenced
this pull request
Oct 26, 2020
[build-script] Remove hard-coded install prefix of /usr and pass it in instead
freak4pc
pushed a commit
to freak4pc/swift
that referenced
this pull request
Sep 28, 2022
Drop building SwifterSwift in 3.0 mode.
DougGregor
pushed a commit
to DougGregor/swift
that referenced
this pull request
Apr 28, 2024
* WiX: adjust the rules for harvesting directories with heat This should generate durable GUIDs at compile time to allow an in-place upgrade. Remove the unnecessary properties in the developer tools. * WiX: restructure the toolchain MSI This restructures the MSIs into a slightly more granular set of MSIs. It reduces the size of the single MSI making the installer proceed a bit more uniformly. bld: Build Tools (binutils, compilers, linker, assembler) cli: Command Line Tools (clang-format, clang-tidy, swift-api-digester, swift-symbolgraph-extract, swift-package-manager) dbg: Debugging Tools (lldb, repl) ide: IDE Integration Tools (clangd, lldb-vscode, sourcekitd, SourceKit-LSP) In the future, this also provides a logical location for DocC (cli), swift-inspect (dbg), and swift-format (cli). Take the opportunity to use the higher compression by default on all the MSIs. This also removes `swift-build-tool` and `swift-build-sdk-interfaces` until we have a need for them. Simultaneously, we are taking advantage of the WiX 4.0 feature to create a dual-purpose MSI. Unfortunately, burn does not support dual-purpose builds and this implicitly migrates the toolchain to a per-user install currently. However, this is desirable as it will likely provide a space free install path along with removing the need for administrator rights. * WiX: shuffle the runtime into `Runtimes\[SemVer]` This makes it fit more naturally into the layout with the co-located installation. Take the opportunity to claw back some storage by enabling compression. This effectively neurtalises the effects of the split MSIs (and slightly wins even). * WiX: rework the SDK layout Restore the components, move the install location, and enable the dual-purpose installer, and enable higher compression. The higher compression helps offset some of the associated costs for the split MSIs. The SDKs are now relocated to `%ProgramFiles%\Swift\Platforms` to co-locate the Platform SDKs with the toolchain and runtime. The conversion to a dual purpose MSI will relocate this to `%LocalAppData%\Programs\Swift\Platforms`. In most cases this should be a space free path which allows us to finally migrate away from `C:\Library` and fix the issue of incorrect permissions on directories. * WiX: remove the obsolete `DEVELOPER_SDK` environment variable This was removed from use in SPM in 5.7. Update the installer to no longer add this environment variable. * WiX: adjust the environment handling to handle dual purpose Ensure that we properly handle the environment when installing. When performing a per-user install, we should modify the user's environment variables and when performing a per-machine install, modify the system environment variables. * WiX: reduce some vertical whitespace usage Remove the use of empty nodes and collapse them to the short form. This reduces the height of the directory hierarchy listing and makes it easier to identify the leaf nodes in the file system. * WiX: rename version.wxi to config.wxi The original version information has been removed from the include file and now only has the configuration for the build. This allows us to use a single definition for the various architectures. * WiX: draw a diagram of the SDK layout The SDK layout is now the most complex part of the Swift distribution. Draw a rendering of the layout to make it easier to follow. * WiX: revert to per-machine installs The uninstallation path is adversely effected by the dual-purpose builds. This allows installation and uninstallation to function. While this still requires the UAC prompt, a working installation is more important. A subsequent change to enable per-user installs is still feasible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted the check that the DebugScope
DSexists and that theDebugScope's
SILFnis the same as theIGF's to an assertionbased on the FIXME's suggestion on line 831.