[CodeCompletion] Propagate completion status of parseGenericArguments() #20960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To properly handle code-completion in generic argument list. rdar://problem/39312854
|
@swift-ci Please smoke test |
benlangmuir
reviewed
Dec 3, 2018
| @@ -1207,9 +1207,9 @@ Parser::parseExprPostfixSuffix(ParserResult<Expr> Result, bool isExprBasic, | |||
| if (canParseAsGenericArgumentList()) { | |||
| SmallVector<TypeRepr *, 8> args; | |||
| SourceLoc LAngleLoc, RAngleLoc; | |||
| if (parseGenericArguments(args, LAngleLoc, RAngleLoc)) { | |||
| auto argStat = parseGenericArguments(args, LAngleLoc, RAngleLoc); | |||
There was a problem hiding this comment.
Shouldn't this status be incorporated into the ParserResult about to be returned?
There was a problem hiding this comment.
Currently, that's unreachable because canParseAsGenericArgumentList() fails if CC token is in it.
| @@ -2259,9 +2259,9 @@ Expr *Parser::parseExprIdentifier() { | |||
| if (canParseAsGenericArgumentList()) { | |||
| SyntaxContext->createNodeInPlace(SyntaxKind::IdentifierExpr); | |||
| SyntaxContext->setCreateSyntax(SyntaxKind::SpecializeExpr); | |||
| if (parseGenericArguments(args, LAngleLoc, RAngleLoc)) { | |||
| auto argStat = parseGenericArguments(args, LAngleLoc, RAngleLoc); | |||
benlangmuir
approved these changes
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To properly handle code-completion in generic argument list.
rdar://problem/39312854